From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Longerbeam <slongerbeam@gmail.com>
Subject: Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit
Date: Fri, 15 Jul 2016 15:35:50 -0700
Message-ID: <57896546.3010202@gmail.com>
References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com>
 <1467932621-358-2-git-send-email-steve_longerbeam@mentor.com>
 <CAP=VYLp+M7ucA0ipzDwaEn4qHOt5yYCOyAwx=9+ON217ou7onw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAP=VYLp+M7ucA0ipzDwaEn4qHOt5yYCOyAwx=9+ON217ou7onw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: p.zabel@pengutronix.de, dri-devel@lists.freedesktop.org, LKML <linux-kernel@vger.kernel.org>, Steve Longerbeam <steve_longerbeam@mentor.com>
List-Id: dri-devel@lists.freedesktop.org



On 07/10/2016 05:02 PM, Paul Gortmaker wrote:
>
> +#include <linux/export.h>
> +#include <linux/module.h>
> You have a u32 field in a struct called "modules" but aside from that, I do not
> see anything in this code requiring module.h -- did I miss something?
>
> You might want export.h for EXPORT_SYMBOL though.
>
>

Hi Paul, yes module.h wasn't needed. Fixed in next version.

Steve