From mboxrd@z Thu Jan 1 00:00:00 1970 From: gowrishankar Subject: Re: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le Date: Sat, 16 Jul 2016 13:29:06 +0530 Message-ID: <5789E94A.6000603@linux.vnet.ibm.com> References: <1468137084-5983-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <000001d1de47$3440a0b0$9cc1e210$@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "'Bruce Richardson'" , "'Konstantin Ananyev'" , "'Thomas Monjalon'" , "'Cristian Dumitrescu'" , "'Pradeep'" To: Chao Zhu , dev@dpdk.org Return-path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id A54E55424 for ; Sat, 16 Jul 2016 09:59:18 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6G7rqTf002984 for ; Sat, 16 Jul 2016 03:59:17 -0400 Received: from e28smtp05.in.ibm.com (e28smtp05.in.ibm.com [125.16.236.5]) by mx0a-001b2d01.pphosted.com with ESMTP id 247dt2ufpn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 16 Jul 2016 03:59:17 -0400 Received: from localhost by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 16 Jul 2016 13:29:14 +0530 Received: from d28relay09.in.ibm.com (d28relay09.in.ibm.com [9.184.220.160]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 00CE0E005B for ; Sat, 16 Jul 2016 13:33:16 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay09.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6G7xB8239649432 for ; Sat, 16 Jul 2016 13:29:11 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6G7xAva021165 for ; Sat, 16 Jul 2016 13:29:10 +0530 In-Reply-To: <000001d1de47$3440a0b0$9cc1e210$@linux.vnet.ibm.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chao, I did not face this error. Even I verified today with tip of master=20 6596554... . However I had patch conflict for examples/l3fwd/l3fwd_em.c which is fixed now and v3 patch set sent recently. Could you please check. Thanks, Gowrishankar On Friday 15 July 2016 08:45 AM, Chao Zhu wrote: > Gowrishankar, > > When I tried the patches, I got some compilation error: > > In file included from > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0: > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function > 'transition4': > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=3Dstrict-aliasing] > *indices1 =3D (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], > ^ > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=3Dstrict-aliasing] > *indices2 =3D (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], > > Can you help to take a look? > > > -----Original Message----- > From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com] > Sent: 2016=C4=EA7=D4=C210=C8=D5 15:51 > To: dev@dpdk.org > Cc: Chao Zhu ; Bruce Richardson > ; Konstantin Ananyev > ; Thomas Monjalon ; > Cristian Dumitrescu ; Pradeep > ; gowrishankar > Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in > ppc64le > > From: gowrishankar > > This patchset enables LPM, ACL and other few missing libs in ppc64le an= d > also address few patches in related examples (ip_pipeline and l3fwd). > > Test report: > LPM and ACL unit tests verified as in patch set v1. > Same results as before observed. > > v2 changes: > - enabling libs in config included as part of lib changes itself. > > gowrishankar (6): > lpm: add altivec intrinsics for dpdk lpm on ppc_64 > acl: add altivec intrinsics for dpdk acl on ppc_64 > ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64 > table: cache align rte_bucket_4_8 > sched: enable sched library for ppc64le > l3fwd: add altivec support for em_hash_key > > app/test-acl/main.c | 4 + > app/test/test_xmmt_ops.h | 16 + > config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - > examples/ip_pipeline/cpu_core_map.c | 12 +- > examples/ip_pipeline/init.c | 4 + > examples/l3fwd/l3fwd_em.c | 8 + > lib/librte_acl/Makefile | 2 + > lib/librte_acl/acl.h | 4 + > lib/librte_acl/acl_run.h | 2 + > lib/librte_acl/acl_run_altivec.c | 47 +++ > lib/librte_acl/acl_run_altivec.h | 328 > +++++++++++++++++++++ > lib/librte_acl/rte_acl.c | 13 + > lib/librte_acl/rte_acl.h | 1 + > .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ > lib/librte_lpm/Makefile | 2 + > lib/librte_lpm/rte_lpm.h | 2 + > lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ > lib/librte_table/rte_table_hash_key8.c | 2 +- > 18 files changed, 649 insertions(+), 19 deletions(-) create mode 100= 644 > lib/librte_acl/acl_run_altivec.c create mode 100644 > lib/librte_acl/acl_run_altivec.h create mode 100644 > lib/librte_eal/common/include/arch/ppc_64/rte_vect.h > create mode 100644 lib/librte_lpm/rte_lpm_altivec.h > > -- > 1.9.1 > > >