From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mengdong Lin Subject: Re: [PATCH v2 0/5] topology: Enhance support for private data Date: Mon, 18 Jul 2016 10:47:46 +0800 Message-ID: <578C4352.1040804@linux.intel.com> References: <578A2F73.8080508@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by alsa0.perex.cz (Postfix) with ESMTP id 839792656F5 for ; Mon, 18 Jul 2016 04:42:44 +0200 (CEST) In-Reply-To: <578A2F73.8080508@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto , alsa-devel@alsa-project.org, broonie@kernel.org Cc: tiwai@suse.de, mengdong.lin@intel.com, liam.r.girdwood@intel.com, shreyas.nc@intel.com List-Id: alsa-devel@alsa-project.org On 07/16/2016 08:58 PM, Takashi Sakamoto wrote: > > Current implementation of ALSA SoC part in kernel has no call > corresponding to sys_ioctl(SNDRV_CTL_IOCTL_ELEM_ADD) or something like > that, thus I recommend you to drop this line by an additional patch: > http://git.alsa-project.org/?p=alsa-lib.git;a=blob;f=src/topology/ctl.c;h=b948ac021ceecc116bc1087075743243e4b14055;hb=HEAD#l44 > Thanks for your suggestions. But this tool is not for directly adding controls from the user space. It's for ADSP firmware vendors to describe the controls/widgets/pcms for a specific version of firmware. Previously, these components are hard coded in ASoC platforms drivers and not so convenient to share a common driver for different firmwares. The topology binary generated by this tool will be loaded by ASoC platform driver with a specific firmware binary, and so ASoC will create the controls/widgets/pcms that match the firmware automatically. Thanks Mengdong