From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP1KJ-0004Ud-D1 for qemu-devel@nongnu.org; Mon, 18 Jul 2016 01:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP1KD-00086e-H0 for qemu-devel@nongnu.org; Mon, 18 Jul 2016 01:42:46 -0400 Received: from [59.151.112.132] (port=21520 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP1KD-00086N-0Q for qemu-devel@nongnu.org; Mon, 18 Jul 2016 01:42:41 -0400 References: <1466592545-9105-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <20160708014823.GA13961@ad.usersys.redhat.com> <20160708085401.GA3205@redhat.com> <23246597-319a-d568-6fcc-738f5eb1341a@redhat.com> <57830099.5030108@cn.fujitsu.com> <578C370B.8020302@cn.fujitsu.com> <578C69B7.2010707@redhat.com> From: Zhang Chen Message-ID: <578C6C95.4050606@cn.fujitsu.com> Date: Mon, 18 Jul 2016 13:43:49 +0800 MIME-Version: 1.0 In-Reply-To: <578C69B7.2010707@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V2] qemu-char: Fix context for g_source_attach() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , Paolo Bonzini , "Daniel P. Berrange" , Fam Zheng Cc: "eddie . dong" , qemu devel , Li Zhijian On 07/18/2016 01:31 PM, Jason Wang wrote: > > > On 2016年07月18日 09:55, Zhang Chen wrote: >> Hi~ All~~ >> >> Can you give me some feedback for this patch? >> >> We need more comments~~ >> >> COLO project depend on this patch to work. >> >> Because this patch colo-compare can make handler of >> qemu_chr_add_handlers() >> >> run in compare thread, reduce workload of main_loop in network busy >> situation. >> >> This idea from Jason. >> >> >> Thanks >> Zhang Chen > > I think you can put this patch in the series of COLO comparing thread > which shows its using. And then you can ask acked-by or reviewed-by > from other maintainers. > > Thanks > > Make sense. I will add this patch in next colo-compare series. Thanks Zhang Chen > > -- Thanks zhangchen