Re: [PATCH v7] hwmon: added kernel module for FTS BMC chip "Teutates"

[Guenter Roeck <linux@roeck-us.net>]

On 07/18/2016 04:51 AM, Thilo Cestonaro wrote:
> From: Thilo Cestonaro <thilo@cestona.ro>
>
> This driver implements support for the FTS BMC Chip "Teutates".
>
> Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>
> ---

[ ... ]

> +
> +/*****************************************************************************/
> +/* Module initialization / remove functions				     */
> +/*****************************************************************************/
> +static int fts_remove(struct i2c_client *client)
> +{
> +	struct fts_data *data = dev_get_drvdata(&client->dev);
> +
> +	watchdog_unregister_device(&data->wdd);
> +	return 0;
> +}
> +
> +static int fts_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +{
> +	u8 revision;
> +	struct fts_data *data;
> +	int err;
> +	s8 deviceid;

One (hopefully) last question: Effectively this means that any device ID >=0x80
will be identified as error. Is this on purpose ? It is quite unusual.

Thanks,
Guenter