All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP
Date: Mon, 18 Jul 2016 11:54:52 -0500	[thread overview]
Message-ID: <578D09DC.4040802@ti.com> (raw)
In-Reply-To: <1468856568-20323-1-git-send-email-m-karicheri2@ti.com>

On 07/18/2016 10:42 AM, Murali Karicheri wrote:
> commit 1f807a9f32aa ("ARM: keystone2: Refactor MSMC macros to avoid
> #ifdeffery") refactored code, however K2HKLE_MSMC_SEGMENT_QM_PDSP is
> left under a macro KS2_MSMC_SEGMENT_QM_PDSP which is no longer valid.
> This, in effect disabled DMA coherency for QM PDSP.
>
> Given that msmc_k2hkle_common_setup is valid for all K2H/K/L/E SoCs,
> the #ifdef should been removed in the first place. Do the same.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Acked-by: Nishanth Menon <nm@ti.com>
> ---
>   arch/arm/mach-keystone/init.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-keystone/init.c b/arch/arm/mach-keystone/init.c
> index 3b6d5ef..6e5a1e1 100644
> --- a/arch/arm/mach-keystone/init.c
> +++ b/arch/arm/mach-keystone/init.c
> @@ -101,9 +101,7 @@ static void msmc_k2hkle_common_setup(void)
>   	msmc_share_all_segments(KS2_MSMC_SEGMENT_C6X_0);
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_ARM);
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_NETCP);
> -#ifdef KS2_MSMC_SEGMENT_QM_PDSP
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_QM_PDSP);
> -#endif
>   	msmc_share_all_segments(K2HKLE_MSMC_SEGMENT_PCIE0);
>   	msmc_share_all_segments(KS2_MSMC_SEGMENT_DEBUG);
>   }
>
please add:
Fixes: 1f807a9f32aa ("ARM: keystone2: Refactor MSMC macros to avoid
ifdeffery")


-- 
Regards,
Nishanth Menon

      parent reply	other threads:[~2016-07-18 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 15:42 [U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP Murali Karicheri
2016-07-18 15:59 ` Tom Rini
2016-07-18 16:54 ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578D09DC.4040802@ti.com \
    --to=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.