From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 5D17760746; Tue, 19 Jul 2016 08:29:24 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id u6J8TOVW019610 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 19 Jul 2016 01:29:24 -0700 (PDT) Received: from [128.224.162.229] (128.224.162.229) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 19 Jul 2016 01:29:22 -0700 To: , References: <20160711133853.11387.69162@opal.openembedded.org> <20160711133854.4638E501F5@opal.openembedded.org> From: ChenQi Message-ID: <578DE4EA.7080000@windriver.com> Date: Tue, 19 Jul 2016 16:29:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160711133854.4638E501F5@opal.openembedded.org> X-Originating-IP: [128.224.162.229] Subject: Re: [oe-commits] [meta-openembedded] 01/44: openconnect: add dependency to fix Makefile.am X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 08:29:25 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Hi Martin, Sorry, but please drop this patch. It's a wrong fix. The below one is the right fix. [oe-commits] [meta-openembedded] 02/44: openconnect: fix do_compile failure Best Regards, Chen Qi On 07/11/2016 09:38 PM, git@opal.openembedded.org wrote: > martin_jansa pushed a commit to branch master-next > in repository meta-openembedded. > > commit 939c471c5ed2471bf457bf21dc219edde68d1a19 > Author: Qi.Chen@windriver.com > AuthorDate: Fri May 6 17:02:17 2016 +0800 > > openconnect: add dependency to fix Makefile.am > > main.c needs version.c which is generated at build time. > Add this dependency to avoid the following error. > > ../git/main.c:78:21: fatal error: version.c: No such file or directory > > Signed-off-by: Chen Qi > Signed-off-by: Martin Jansa > --- > .../0001-Makefile.am-add-missing-dependency.patch | 28 ++++++++++++++++++++++ > .../openconnect/openconnect_git.bb | 3 ++- > 2 files changed, 30 insertions(+), 1 deletion(-) > > diff --git a/meta-networking/recipes-connectivity/openconnect/files/0001-Makefile.am-add-missing-dependency.patch b/meta-networking/recipes-connectivity/openconnect/files/0001-Makefile.am-add-missing-dependency.patch > new file mode 100644 > index 0000000..c465bf1 > --- /dev/null > +++ b/meta-networking/recipes-connectivity/openconnect/files/0001-Makefile.am-add-missing-dependency.patch > @@ -0,0 +1,28 @@ > +Upstream-Status: Pending > + > +Subject: Makefile.am: add missing dependency > + > +Add missing dependency to avoid the following error. > + > + ../git/main.c:78:21: fatal error: version.c: No such file or directory > + > +Signed-off-by: Chen Qi > +--- > + Makefile.am | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/Makefile.am b/Makefile.am > +index d823e01..ea48ec1 100644 > +--- a/Makefile.am > ++++ b/Makefile.am > +@@ -112,6 +112,7 @@ EXTRA_DIST += $(shell cd "$(top_srcdir)" && \ > + > + DISTCLEANFILES = $(pkgconfig_DATA) > + > ++main.c: version.c > + main.o: version.c > + version.c: $(library_srcs) $(lib_openssl_srcs) $(lib_gnutls_srcs) \ > + $(openconnect_SOURCES) Makefile.am configure.ac \ > +-- > +2.8.1 > + > diff --git a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb > index 6d3c252..d8fe439 100644 > --- a/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb > +++ b/meta-networking/recipes-connectivity/openconnect/openconnect_git.bb > @@ -8,7 +8,8 @@ RDEPENDS_${PN} = "vpnc" > PV = "7.06" > > SRCREV = "35542d52202672b8c12ecc63867432128244013a" > -SRC_URI = "git://git.infradead.org/users/dwmw2/openconnect.git" > +SRC_URI = "git://git.infradead.org/users/dwmw2/openconnect.git \ > + file://0001-Makefile.am-add-missing-dependency.patch" > > S = "${WORKDIR}/git" > >