All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Wei Yongjun <weiyj_lk@163.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	airlied@linux.ie, David1.Zhou@amd.com, Jammy.Zhou@amd.com,
	Monk.Liu@amd.com
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/amdgpu: use list_move instead of list_del/list_add
Date: Tue, 19 Jul 2016 14:08:34 +0200	[thread overview]
Message-ID: <578E1842.2090802@amd.com> (raw)
In-Reply-To: <1468929714-8736-1-git-send-email-weiyj_lk@163.com>

Am 19.07.2016 um 14:01 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move() instead of list_del() + list_add().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 0307ff5..aba38ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -414,8 +414,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>   
>   			if (e->robj->tbo.ttm->state != tt_bound &&
>   			    !e->user_pages) {
> -				list_del(&e->tv.head);
> -				list_add(&e->tv.head, &need_pages);
> +				list_move(&e->tv.head, &need_pages);
>   
>   				amdgpu_bo_unreserve(e->robj);
>   			}
>
>
>
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Wei Yongjun <weiyj_lk@163.com>,
	Alex Deucher <alexander.deucher@amd.com>, <airlied@linux.ie>,
	<David1.Zhou@amd.com>, <Jammy.Zhou@amd.com>, <Monk.Liu@amd.com>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] drm/amdgpu: use list_move instead of list_del/list_add
Date: Tue, 19 Jul 2016 14:08:34 +0200	[thread overview]
Message-ID: <578E1842.2090802@amd.com> (raw)
In-Reply-To: <1468929714-8736-1-git-send-email-weiyj_lk@163.com>

Am 19.07.2016 um 14:01 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move() instead of list_del() + list_add().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 0307ff5..aba38ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -414,8 +414,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>   
>   			if (e->robj->tbo.ttm->state != tt_bound &&
>   			    !e->user_pages) {
> -				list_del(&e->tv.head);
> -				list_add(&e->tv.head, &need_pages);
> +				list_move(&e->tv.head, &need_pages);
>   
>   				amdgpu_bo_unreserve(e->robj);
>   			}
>
>
>
>

  reply	other threads:[~2016-07-19 12:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 12:01 [PATCH -next] drm/amdgpu: use list_move instead of list_del/list_add Wei Yongjun
2016-07-19 12:08 ` Christian König [this message]
2016-07-19 12:08   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578E1842.2090802@amd.com \
    --to=christian.koenig@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=Jammy.Zhou@amd.com \
    --cc=Monk.Liu@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weiyj_lk@163.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.