From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH -next] drm/amdgpu: use list_move instead of list_del/list_add Date: Tue, 19 Jul 2016 14:08:34 +0200 Message-ID: <578E1842.2090802@amd.com> References: <1468929714-8736-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0054.outbound.protection.outlook.com [104.47.34.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A8676E2FC for ; Tue, 19 Jul 2016 12:08:53 +0000 (UTC) In-Reply-To: <1468929714-8736-1-git-send-email-weiyj_lk@163.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wei Yongjun , Alex Deucher , airlied@linux.ie, David1.Zhou@amd.com, Jammy.Zhou@amd.com, Monk.Liu@amd.com Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMTkuMDcuMjAxNiB1bSAxNDowMSBzY2hyaWViIFdlaSBZb25nanVuOgo+IEZyb206IFdlaSBZ b25nanVuIDx5b25nanVuX3dlaUB0cmVuZG1pY3JvLmNvbS5jbj4KPgo+IFVzaW5nIGxpc3RfbW92 ZSgpIGluc3RlYWQgb2YgbGlzdF9kZWwoKSArIGxpc3RfYWRkKCkuCj4KPiBTaWduZWQtb2ZmLWJ5 OiBXZWkgWW9uZ2p1biA8eW9uZ2p1bl93ZWlAdHJlbmRtaWNyby5jb20uY24+ClJldmlld2VkLWJ5 OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMgfCAzICstLQo+ICAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jIGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiBpbmRleCAwMzA3ZmY1Li5hYmEzOGVjIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiBAQCAtNDE0LDggKzQxNCw3IEBA IHN0YXRpYyBpbnQgYW1kZ3B1X2NzX3BhcnNlcl9ib3Moc3RydWN0IGFtZGdwdV9jc19wYXJzZXIg KnAsCj4gICAKPiAgIAkJCWlmIChlLT5yb2JqLT50Ym8udHRtLT5zdGF0ZSAhPSB0dF9ib3VuZCAm Jgo+ICAgCQkJICAgICFlLT51c2VyX3BhZ2VzKSB7Cj4gLQkJCQlsaXN0X2RlbCgmZS0+dHYuaGVh ZCk7Cj4gLQkJCQlsaXN0X2FkZCgmZS0+dHYuaGVhZCwgJm5lZWRfcGFnZXMpOwo+ICsJCQkJbGlz dF9tb3ZlKCZlLT50di5oZWFkLCAmbmVlZF9wYWdlcyk7Cj4gICAKPiAgIAkJCQlhbWRncHVfYm9f dW5yZXNlcnZlKGUtPnJvYmopOwo+ICAgCQkJfQo+Cj4KPgo+CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbcGSMlv (ORCPT ); Tue, 19 Jul 2016 08:41:51 -0400 Received: from mail-bl2nam02on0047.outbound.protection.outlook.com ([104.47.38.47]:3067 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753327AbcGSMlp (ORCPT ); Tue, 19 Jul 2016 08:41:45 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH -next] drm/amdgpu: use list_move instead of list_del/list_add To: Wei Yongjun , Alex Deucher , , , , References: <1468929714-8736-1-git-send-email-weiyj_lk@163.com> CC: Wei Yongjun , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <578E1842.2090802@amd.com> Date: Tue, 19 Jul 2016 14:08:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468929714-8736-1-git-send-email-weiyj_lk@163.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:b59d:82b6:5d65:c82d] X-ClientProxiedBy: AM2PR09CA0077.eurprd09.prod.outlook.com (10.160.228.173) To MWHPR12MB1312.namprd12.prod.outlook.com (10.169.205.137) X-MS-Office365-Filtering-Correlation-Id: d6a50fc5-8d1b-4fa8-4e35-08d3afcd71b3 X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1312;2:cCCFVvRGebVSZ3CpwHsrAlFWt/sMrWvhneT5BD2wUYsVnJgp3A8INL1/LDtoWN5SZI9g+PA7LRfc+zOa3Xst6pfaGUqL2zHEeFl+i6K/k8/+Xg/ouw1DIZ4se+qzCcMSjZ7sS9NGaOnW1P4fDaJjlG+WtxSHDDvrKdP7A3laxG6nkg/OtAmTC/nCjRZ46eqU;3:pqLw9vsUaXehhpIxtUzjG639+c3mFRSUzD9ZuHWW8A9cZAsaYU5Cd9ym2zmiU2URcoutXYOpgGjOUmvRnOCYQPUnis/MLo3lx0Q5xS4W6M+cfDFCrSpw7GKC4NcIXcb0;25:6Zzn2H0uSDGupsxWPN9ki1FC/5zA+czBHZxZLI8RAU+ddpql26eXB6jBQI+e159kNylGJ/r1jccijA1XlWpOofptAu818lCvtof66ooKszrJSxF5WIJ/0+WVaCSqsKMNcQaI6AJwQ0kdL9e8j3r426QW9GqIcPBzqZlGBXx6xJ6yRQudE7l6MYYgf5b8N5PlMFRM3R2fGrE77TxlEzdJJoY4JTqyNVZRFZN+pfnpLmWv1I0rqVX390nETeDEhWosIEQp3N3HNx5kyKPLR1Lga5z0mo8jkxYfU2cyU/0HQslPcIAexiI7khIwic2QBOHlwTyvLwWc7KGZOIngnEJc0DSBeGCCTLP27w94d538nZHK7dWtMyZWrNabk4nCsVf8WrH93J4ZtyUYqk3G0X+hhEe0vYbfgwrN8l3kogNvNME=;31:GP4ZUhRIC5tYKvzGqQIWPgMlNbdmAJ2p6xNJcrxGld5qoYemJxOkYEYewJ+Qc9dawWKc1ylCvBUfob96+LiNubn/jR0QwdrBKlhDHVJgK5YLjwAOeBI9aYSzUvXasHys74aIAXt1XR3K0chLJ8VOaTgYERMTMfhnQjjM+M6SuKohhmEuGUg6fygQNUQKu3KPIhG7lSef8dX6eKOlyrzyqw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1312; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1312;20:dZw75GoEkkv3zALHIrhjKZIhs/DYjP3li2xd02kK1wnc6akH0tYmL6naXc+9cM1nR2DNNtcsD6VkGMI7DFzGTx8mDzZE7Df+N6rf5jxgqF8lyBUW4aUrnBBgQq2ZHAsD1uZTRPE0fhndiE3p8GuekEAlsY7YEwTuRNiKQseJSR+UDDZOLgagzD7P3rNgN0PPOrPV/hw5VwZJHBY+eGXIwZeqESdngfdqwWDt881eH5wTVHPuOWKo+Qw/D1JAL2urB6tPdDo8TzjCdao2sZrE3izmNfS88Im7p7UmIrxwC553G2PyzokLemLqdeoZ9aMY++z6OVTl171zs3z1VTx43cnjXkASlAy78hu6wnrQAfojc/c7GC7zQZxJej2873K9sml2msUon5kokYf4MF5TLIYD9hb9mnjEKHKTUH40G7qFz1QdXoILCVBqQBO2kRsSEMeQ7L9EdRP6LbpCm++Tk+snN0v91GSFVnbX9suuISBtTJczH3iDrZSZdJm8v6oz;4:d6T/v1vokeU8wa0zU8A/QldN5gzEnCRaQNphS/v0dHn5csOq5AK3bFsv9zFHtlU8mskTr8GE63/lpQClaqzrlNZ6hZQSIHHL//WDEjeDPNHoR9TRyFGw8BeD5KHvQaWJ4FYHnHZ/FbgInXg9eq60Pgp/HnDG7Tq4zVk0+c1hocu+epGEubn3PkhKCQyjzNboA7IRXme42dEP447N/zrfxU+9c8PQPbqfxo42VWuXERrZsJm7ys3kmGnKlWx3PlvGFxoTpXWsumi3fm+FmGAlo68bDl6zpdp89gBXN6g0t/lUmIb72HSpXqkRiUO8qlnYP2TWvpT6qOf9VehGyz3mPZUhFdHXQ+V8vriM1PNuKDpOecOLb5e9ux0N+rMTEBtQ0fivULurwA1R4QtzGc7N7R47rKcCsvRMu/+Gtzywcoo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:MWHPR12MB1312;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1312; X-Forefront-PRVS: 000800954F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(50986999)(7846002)(7736002)(77096005)(2201001)(76176999)(54356999)(87266999)(65816999)(83506001)(586003)(42186005)(65956001)(65806001)(47776003)(105586002)(8676002)(101416001)(4001350100001)(4326007)(97736004)(305945005)(1706002)(5001770100001)(33656002)(2950100001)(92566002)(6116002)(80316001)(189998001)(106356001)(36756003)(81166006)(81156014)(2906002)(19580405001)(64126003)(19580395003)(68736007)(23746002)(2870700001)(86362001)(59896002)(50466002)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1312;H:[IPv6:2a02:908:1251:7981:b59d:82b6:5d65:c82d];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR12MB1312;23:aSJV6Epyc22QXYc6WYFLE7/54z+5qlR39axeD?= =?Windows-1252?Q?2Tl0/ar/ESw9r0yIsOw6vTJbF4afWfY6lFARcN/cUW+Iwv6sAEWR1DHr?= =?Windows-1252?Q?9S7cqZoNCGe+dWTEfayefr6nnp5ZCBxbZM7NA6X3HhfJfg9cjWaN31b9?= =?Windows-1252?Q?bjqmdDrU5WwotYLM8bYiFDmzGaeyX+plZyqe54ECjibKd1PmOndli7KE?= =?Windows-1252?Q?WgtlfRUYg39oHdG8LkKccSyBfvLU9XZVWQyWCX0eapvRe2WR6+ie0iMp?= =?Windows-1252?Q?4z3GjaZC/yoZ42Us8aAj6SXxazwCKvjTRvyHOAbZjtl1iRJ/y5tPUmxi?= =?Windows-1252?Q?/RV+ptRrK/5uZ+gdWe0ZI90Cn1yf8Vqx6d156pdJLwY+0sxb9JdSxnHK?= =?Windows-1252?Q?yIDc38aY+fPhC2uoOE4zWO+QDlAJeRno4c3Lknkn3ru2XgVMmzJCx1wc?= =?Windows-1252?Q?2ww8baNhBswOuuQ7aike+H7VLSY9O+RCMfBNbeNgPXI/09wVm1D8Khnn?= =?Windows-1252?Q?akzoWPcq/9Ne9jvGG0IXZhRWQJayyy1CmYPYpAeD8ea8Zt2NmeMdR2cW?= =?Windows-1252?Q?6ofNopYRZ9g9n7xsNQzOmr/sn52hs3fEjihaE3hzoVrKv13dzRZ6bOiH?= =?Windows-1252?Q?jKJ1+yt6yumC+o+nnNQAq2N6I8Kh8YuKi8UrkVkHOdYfwHYQMbUxhSHr?= =?Windows-1252?Q?kgYnjkRkZ9Sf3sZPHW8yjHQsWczdKmmAo5Ecal2v7aESF6yTRrr6F2iq?= =?Windows-1252?Q?0/TzA0Gt0sMeUHAcT6n9U4IFVmIdrVlTXnogxL/M9rR9Ag8J5BPPWvn7?= =?Windows-1252?Q?A8s5NBKvFWodnnd7Yz3Z3Etotu9JzSQXhanc6ncuPTRm5t8PrT4NW/v+?= =?Windows-1252?Q?MCYvo5iHTkRfUY/7o0VA12/debvuct2PCAtfhprfFVsf3FzSzQNSC9vc?= =?Windows-1252?Q?rXEupqK22eHoNvLNVBFSLKN7G0s12tWQx9iCAQSzxoaNfRq96dHrB5RN?= =?Windows-1252?Q?YpguEtrNdARX6jWr2cVQare7LsU0EnJ5u/Tg/bGSGDGQRwOaujGyNOnH?= =?Windows-1252?Q?LzYRg3ZtDwttbNyf8SBah7BHGq7eA8KuXTMuJ9q3PJ3xjpTsOhBNaKIQ?= =?Windows-1252?Q?qSxHQLcQJobO2S2OBqPF/mVkBZd2TO20TXM1mENbe26Np+lEm6ZtkxUK?= =?Windows-1252?Q?jBsNAPbdsSdv7/eD+H2XEPvUd+YxXeKYCa7lHkkVDUm5dqSGCGFjsCrr?= =?Windows-1252?Q?HL2Gw6GCE1/jv3j3e9mz4UNbM5HmPqDLOHIQmJxkCb71ajQ4XQ91wLHA?= =?Windows-1252?Q?OCiy1HGXScDwE9Xj3Bdc9Qs9LoXy5ccRAaRJXsGGx7ozFravwm1Pj31y?= =?Windows-1252?Q?WIBSof2oN0r?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1312;6:DGW+egbFNhi2rQeNkQ58vYa5sFv5xNppoBLJ4q34l8wWNy/QZckImEENkZxPhZSv9uITo79P2SSjDMuFBJwx0TnKcxuSmRLwuusN0zeOvrDdfO9fPnx2DJjMbkPtXXDQc1IIqkBo0Rofwe+ixmD6pojrKW6TeHdfW1cFgAJHCndYay3aq++Vbq73ZO30hGjIiw9blr5cvHS+iC7WGcuz0RxNfgaX3C1B6JhwvcrNS8jqcRK4wbBNwzWMx6oSav3S4T+tsTIp8epViCgR5vX9wM2xlj8eGxOz/y8vVkoCXoY/EDP34ZEkbVGcCvAsNPjz7PeyUV+DgdDu5AInCoP2TA==;5:RBpnWcoUR/HchF7gbya1szBMWU/k+eRuzBuXcSdqF4m8o7SuCz8VoRfyooY6/ONHZ+e68hM4WUFWEEvAJMPQFAPT5wtTDHAazjSemRQUdFqIwOr/2BYLrN2prKWEAWtiVhOilPSkS9pXlS9u3dGL3A==;24:v+jk9McaGDlskSpnG14ZWq0YOctquWXZ6xEXIQPCLDIrTl8v1aodV1tGyWy1KwjhPOAVMY16UoIV+5jUYdbySSd0rrpE2JYrk/7nAetffVg=;7:YvcTyWq2gfHDuqC/Dl9nXZdSXrMJP6uCTIoB4YVNDvvBAi8fLcCx0b1psgat9V1LpUjUCrZRbhJkeacyDaTNvhQtx9vO4tE/6gZB6bEqmqIMcQlA8udIA1z/6tAoTFsRF+7weF3iQDoLXRPvypo7nrWxJe35suQeQfX9MQK6CKRr3BR4wwlfhYqmIDkJ2PyulIvijCXM0tXb0ieYDQavTwKYtTXkADO5pGou7J3E4Y2VB79vPFlVOjbN56F4ehX0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1312;20:aZqKgQr9ZIqDmznSH7WqdNkSLi4GnRiN6zgcrC0NaR9lMkdC9f9NtqZz6AJInYAjD9AYh8dspP63b62PoBD+qQ0kiCqmyB234xnwWVLqWiB/IGl6RmtcHfoCHu6K0fDjX/Btsc7Wkx9dMe4NegT18ijQncKFbsxUo19Cg5bcsnUHy+dFrL6QxfKwKnKc0IndsiBP0vdGHL4xQuwhosPHNJMqD8kG+ogwxW9vRqhUH7L/GHIGzAC+z3o4ByUcudHc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2016 12:08:48.1489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.07.2016 um 14:01 schrieb Wei Yongjun: > From: Wei Yongjun > > Using list_move() instead of list_del() + list_add(). > > Signed-off-by: Wei Yongjun Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index 0307ff5..aba38ec 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -414,8 +414,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, > > if (e->robj->tbo.ttm->state != tt_bound && > !e->user_pages) { > - list_del(&e->tv.head); > - list_add(&e->tv.head, &need_pages); > + list_move(&e->tv.head, &need_pages); > > amdgpu_bo_unreserve(e->robj); > } > > > >