From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_debugfs_regs_init() Date: Tue, 19 Jul 2016 14:25:14 +0200 Message-ID: <578E1C2A.9040706@amd.com> References: <1468930488-10230-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0086.outbound.protection.outlook.com [104.47.34.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D8E46E68D for ; Tue, 19 Jul 2016 12:25:29 +0000 (UTC) In-Reply-To: <1468930488-10230-1-git-send-email-weiyj_lk@163.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wei Yongjun , alexander.deucher@amd.com, airlied@linux.ie, Flora.Cui@amd.com, David1.Zhou@amd.com, tom.stdenis@amd.com, Jammy.Zhou@amd.com Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMTkuMDcuMjAxNiB1bSAxNDoxNCBzY2hyaWViIFdlaSBZb25nanVuOgo+IEZyb206IFdlaSBZ b25nanVuIDx5b25nanVuX3dlaUB0cmVuZG1pY3JvLmNvbS5jbj4KPgo+IEluIGNhc2Ugb2YgZXJy b3IsIHRoZSBmdW5jdGlvbiBkZWJ1Z2ZzX2NyZWF0ZV8qKCkgcmV0dXJucyBOVUxMCj4gcG9pbnRl ciBub3QgRVJSX1BUUigpIGlmIGRlYnVnZnMgaXMgZW5hYmxlZC4gVGhlIElTX0VSUigpIHRlc3QK PiBpbiB0aGUgcmV0dXJuIHZhbHVlIGNoZWNrIHNob3VsZCBiZSByZXBsYWNlZCB3aXRoIE5VTEwg dGVzdC4KPiAoZGVmaW5lZChDT05GSUdfREVCVUdfRlMpIG1ha2Ugc3VyZSBkZWJ1Z2ZzIGlzIGVu YWJsZWQpCj4KPiBTaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1biA8eW9uZ2p1bl93ZWlAdHJlbmRt aWNyby5jb20uY24+CgpSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtv ZW5pZ0BhbWQuY29tPi4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfZGV2aWNlLmMgfCA0ICsrLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2RldmljZS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rl dmljZS5jCj4gaW5kZXggNjE0ZmIwMi4uMGM5OTJkMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKPiBAQCAtMjUzMCwxMiArMjUzMCwxMiBAQCBzdGF0 aWMgaW50IGFtZGdwdV9kZWJ1Z2ZzX3JlZ3NfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl dikKPiAgIAkJZW50ID0gZGVidWdmc19jcmVhdGVfZmlsZShkZWJ1Z2ZzX3JlZ3NfbmFtZXNbaV0s Cj4gICAJCQkJCSAgU19JRlJFRyB8IFNfSVJVR08sIHJvb3QsCj4gICAJCQkJCSAgYWRldiwgZGVi dWdmc19yZWdzW2ldKTsKPiAtCQlpZiAoSVNfRVJSKGVudCkpIHsKPiArCQlpZiAoIWVudCkgewo+ ICAgCQkJZm9yIChqID0gMDsgaiA8IGk7IGorKykgewo+ICAgCQkJCWRlYnVnZnNfcmVtb3ZlKGFk ZXYtPmRlYnVnZnNfcmVnc1tpXSk7Cj4gICAJCQkJYWRldi0+ZGVidWdmc19yZWdzW2ldID0gTlVM TDsKPiAgIAkJCX0KPiAtCQkJcmV0dXJuIFBUUl9FUlIoZW50KTsKPiArCQkJcmV0dXJuIC1FTk9N RU07Cj4gICAJCX0KPiAgIAo+ICAgCQlpZiAoIWkpCj4KPgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753211AbcGSMZa (ORCPT ); Tue, 19 Jul 2016 08:25:30 -0400 Received: from mail-sn1nam02on0082.outbound.protection.outlook.com ([104.47.36.82]:20352 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752896AbcGSMZ1 (ORCPT ); Tue, 19 Jul 2016 08:25:27 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_debugfs_regs_init() To: Wei Yongjun , , , , , , References: <1468930488-10230-1-git-send-email-weiyj_lk@163.com> CC: Wei Yongjun , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <578E1C2A.9040706@amd.com> Date: Tue, 19 Jul 2016 14:25:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468930488-10230-1-git-send-email-weiyj_lk@163.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:b59d:82b6:5d65:c82d] X-ClientProxiedBy: AMSPR04CA0030.eurprd04.prod.outlook.com (10.242.87.148) To BN6PR12MB1297.namprd12.prod.outlook.com (10.168.227.147) X-MS-Office365-Filtering-Correlation-Id: e6127398-6980-4837-5ea8-08d3afcfc325 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1297;2:3Yx4Djm+i93t8iozR6AC9cLNtJWywbFkVUz8gfUfwNEkLSWSXz40TXaFOpqG2PwNnomHHaBnvCRbAUGgWg6ueKpo6psgiF1B5CG9mcVynjp1ELSwn5dFHPQ+tTGVkLCxoS+9Q6Pf1M9HyPTUNZfEZrRjNydmXof7vE9ivY9jRaBsfFH7IeRorwe+LM7nidrX;3:5aY7KgeYwbwBciGaLdT1U+Rmq19i8tVNJWnblvCmvoW2bQI2BndRNRW8oPKjgvgube9hJ1p0bBMCecm6hMzn0gw7RWoIKsDkwsVksdSkxH4tvRH/VGW+lOWacgwn9qDw;25:vvhcNdoZgZZkuxjbWBZT/80Gj2v1bmHsZRE1r4VlY3jcv1QqAZ0jyvRxD3i3qs5gfb9isAbx6kWfrkjZ+BK1c8Du5vVVKnGZwTknK8nGvqx2RWjC+VQvJzg7oERGNMoqRF/pbEtPDHmrtF84P2r19+hoNb7cwPW5f4V8h6X/ZtDBYFdgqKCMw72LcjkDKk5kq4OoSUlaxlGM4TypEiDC5fsVKm22z/AjFGGJedCr1d9uZ/9nE7KfIGLFNcjcU/cxh87D87mBKGhFc8RJJELGq0LNs3xXn5buFhTaNv7s0WSlqNvOcc1fSRS/sVZJTVKGEiBsfYqGD2+RAVPnQyQzoRT//XdB1mky/xVywwPeqoYrO4atCR13Xd3feQzX8r4Z7/pTPuYpjSNdpp4UpkBFLaFhKYvrkeU0Nyz4NkL7O4w=;31:NzaOQwP5S0fmSyYWT+2DvLDvvBYz0pKfh+SBPT0/AE+0GIVHmidSElW9gG4zSJspwEeVvN9ywIIitHo6vRdU42sEO+++taXkw826GVsAqVU9pxOAPxANG98293KwDvBJyc8Dbdebh2EIHCC5qSAyBk3sJfMEMQh8jNW1yn5I6j5LpZ3HVtIj3Vpe6sG5hcLnnnCapuSMNxl5IPRRiSfIyg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1297; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1297;20:1Gm5LNcK9UaoxmEdowT93pP82H3BJR6W1MY+e+JOEI/d8XkV+s157BOeV3CWcPaVxN77EI2ZzrfwtKV/Hw/LxSx7ybzo9HGkelsil6jN9YlX1cfywS7wQE/G9iNpUIkkR+FrY1cwaKtW9Wwdp5fLc3K4syKlzuRkUomNYMWpxMPdt8X+DmNVZA9zGvIb42Y2uTO3wQQqOujLR6SaoAtAg2uJmVI5rFYUw+d+QrNM6i/MSmwUEZV8eUg/cwJuklGzW9xbbyL+At9IY8dtdUViEiuXysoyKyLfl/3gKsLQiCDSoAkl+rRy8ihe+YCbw0m+jVarFfbFccxIh3ZmRtYy0BoxV8URnfYyXOHSINMu+vShGyiapMXSt+rzmyDlQDti+NtJ0XyYFphJ2Oof5fS2Bk81gxJsHIuKSMrw2gpREdBCcWJ6dYOmehv6JHXQTkIgvG7bTrmNGZigTvnfYninNXssn0AIPyHxLR1eT7kNZ4EFGV7WiCt6TY8UN5TxMTpu;4:v2f/ZXtK2kPs93YZJyKB11FOLOcEuuJbmuHnNwV8wNBzXtWD/7GimJBrwtrj6whYC8eRbt1WGAV4NPCLNUN18GUenhNhYqKycw7feWIEesC4RMlcnP/crrs+io9gVuWTkAuF/BjmAr4ZyVCiGVyd6L5xihoA850Y9exGOwAy0YUJbezCn3m94XMTX3xpwCaq2VIZYn7k3LNZBoauq8QIFYKp2P9LNLAEK1h0rD2eafZecJSAT6wSGnFMtXf819jVI7EKVDYXcYV+gCN61ti7ZH89opkC0C4NfT1dIA/VCRjBUMkk1rqHfCESc6U96nbTS0KKAuvrlCztWmVUfo3gZED2oeOGGa2htWshsvsLwlWDspronVj9M6WMftuJS3PDeKGisw7T2niVtC9psQ9iAUqjg8FmSNtmIF/wkBl7/Ds= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BN6PR12MB1297;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1297; X-Forefront-PRVS: 000800954F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(2201001)(4326007)(68736007)(2906002)(19580405001)(106356001)(1706002)(65816999)(81166006)(81156014)(50986999)(7736002)(87266999)(7846002)(36756003)(305945005)(19580395003)(80316001)(101416001)(105586002)(65956001)(4001350100001)(77096005)(2950100001)(47776003)(97736004)(5001770100001)(83506001)(65806001)(23746002)(92566002)(33656002)(50466002)(8676002)(42186005)(2870700001)(59896002)(86362001)(6116002)(586003)(64126003)(189998001)(54356999)(76176999)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1297;H:[IPv6:2a02:908:1251:7981:b59d:82b6:5d65:c82d];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR12MB1297;23:d5r8DUsd6PNfi0Y73L+47IHawkkwZdofmIsMx?= =?Windows-1252?Q?d0kJXSI/pq8DJcQGGw1ITqIRy0dm8pOCBsUAWbo6DTt2MJIyyR9ksibm?= =?Windows-1252?Q?Rl3uqH2cZ7XjKHFVDhWzA+KocQkhaC6BpAlRPpSxksFq88vSQoFgkc63?= =?Windows-1252?Q?s0CSRKXmFD3VEuhHDUtOWMytHra+8ZBXVGprQKMRzKyKCx7YTacz/YEf?= =?Windows-1252?Q?iAL8m+/yiMSM43QOUqrf5fl16RRwkIyzwMurssTaeVzzzrMrZcrQ4G9q?= =?Windows-1252?Q?aVg0I/ZwoDk0TEIDH0ShqUvwjVHCVCiKwMUzzDtBaBrNHR20yRBvqiCI?= =?Windows-1252?Q?hC5aeJWaFMUSVIZ/hYETgNWmrHFjbr6uGVjxG5bTVxxCyhLv2TeSk/jb?= =?Windows-1252?Q?uzm89w6SEcvkoWQ2epgJzViW46g2b2bOJsc/1Umc+3DUSPEAqoZQLI9Z?= =?Windows-1252?Q?MLrD5Q3360ip2jPjfrqna63pbktI5zM+DZ50SYU3/3yHFcVCfNgzHzwb?= =?Windows-1252?Q?3q4lXQUyjZis2MKnUsgvQWNI2WyquYryPthqyLWb/fxlrfl3yBpfwBcc?= =?Windows-1252?Q?j5AdFJSovSaC63qhf3pp4eXV8zd3it7oVKS/ipZmLuiAbG7JoGye2T3F?= =?Windows-1252?Q?mJ8oD4EHZ/Hycc3WF7Rpsy0lBL0an7TA4SQir2yXVPOqY2G//ZZo7/j3?= =?Windows-1252?Q?pfDEe7zaao+8xv13rxfGqSGccpR8FcVbyqQKrtFKI+qlw/RAgf9wgxqA?= =?Windows-1252?Q?ZQd7sxCOlO3mncigc5V6kw5oiudLC43z1NnLulPgjdJ7GneBi2phaI8N?= =?Windows-1252?Q?hOrv2eCvCkVMiA2awpkGJQ2zPmkxWiXWMZs9wQQScyH5KzKrL+QV28K6?= =?Windows-1252?Q?mSbznpxDd+izs1epJCcr4hkiuMzv4h9JS+UReZ9zMEePeKENrcZ5KIUO?= =?Windows-1252?Q?BwZ/ZvXNUh5EakHEmsehWx76H93ohjIRwGx4ZXKd5syQ9qcrqqkKMCxy?= =?Windows-1252?Q?dO+X6+MrGougg60n262iUOV5sHX3AkAhLEnOKJI2Orf1nQkNTxaNiwHK?= =?Windows-1252?Q?FFDNUc8SZblUxzgXyorVzf0k76PaNtDGCtpvqkbnlEJwkZKtBETtt8XE?= =?Windows-1252?Q?X679EkHMpch8KQK5aG/stcuULXkP6a9w9/aChhFQZo6mILLwCVx1yFSL?= =?Windows-1252?Q?ZfAw7CSDfeXvWjHZPT1zOzX1l3OgxZ6dYvoo4eBFwgVVbbBOconixNtr?= =?Windows-1252?Q?BT6oK/Ii1bkOojXAZCyQe04Othh4LIjVXsyP1Y3t9tVPWqtRiXCfSUxt?= =?Windows-1252?Q?tNv7E+49NevFECgKRN88L+S5Y1eYyt6osGFhKmt791rCsS/521BiV2/7?= =?Windows-1252?Q?QyAcGW6v4Ro?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1297;6:QGiap6q87alKUdt7q4d/sAQohz8PV5bRllYZJxW0QsQ+LYBLd5DRBzhxbsO04NOX8BMg9uVTMhnzuV06vpDUZH1nSXiMFK/D0HVsa7zgTWPG6jcKQsJ+Eeud5uvIiAUF8683YDjH/9oWNwVSTYLm2Gr2/0FTUNQqtgyBm3CaDfBUz4LTXkgI0HyzZqpsyHu9mwA6H+3P6gyzrH0bvexMz7vsoomgKq6cCcd9QqTkU1NwoqtF5qVBFFQMh918VvdR3/7CzY9zXobtTtRpNgXTcyKbg4JWMsQd7ZGo5ccBlsF7pz+OGoGk12WlN2rHQUCcJLkJRsD6ooFlwmeOxB086Q==;5:dSxnpHCeYYdvoqBqXttDkoK56fvBE/mO1H4Zq/Y1038Kcv1jaKzjbeMLpYzsqRVErX+1UUEoGgQgko4amGmOn2k/eqcrugmUq9lVzbp6ntBqXLQ1r7hoZRkoRK7NrIkBVLetvTFeaJsbEJhJyPmURQ==;24:+Mf+DkoUuEPFi2rrvh94CT05CQn7eHUVQxmCkXw+YptHDHK8w9AUPQEKXYc7Dwx1DHECMjmCayEA4NuFLR4rxVU0xhOnfiFoxfdyN6cpAMY=;7:MWRZ8UjUme77Pzyf+4fz9KbTx/KY/e1hbbNp08dPOyik7aM4Xissd/+oNeYucmfOmSoln5KVaa9gS1N7Kt5sRrYe7RIc6XcTWcHl2cFSP08dIcrS5q8Zvib+m/qLTQR5+Fcv1tLk+UoBKrMzJlnhjEanXozyvh9TFI6ZjsiDLUDIQ+TFJnItrWq4jtZxA+YLtZLfqWDhRQd6KHhiXvgdf/nxqPHiSarSH870IxL8zd2XQOMw/QSV1zP+U6q2BlI9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1297;20:Jdl8zj8x7SX0vyypL3luyzPU7YRrXBZSOWuoJy9Gq6RpaF4/RJSlwxsoY9G77/6pvKOOSq241aOQh8xQXeaJNs7wNHJ2x6NcR1lrLvigl1Xkq62L7Ukmo5OQRtmuiDmT4u1bk2Sxc6Y7Zizyb3IQWJCm4wJZ92rNi8UHeI74TaxXYU9YLS4G/kE9XeKFA5s0Ky2qs0gzAX1Jt1FEFpbvAHycdk9iSHdfDAINlgC8iufPZ+S4gC0P2SvnpLNyTA2I X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2016 12:25:24.0335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1297 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.07.2016 um 14:14 schrieb Wei Yongjun: > From: Wei Yongjun > > In case of error, the function debugfs_create_*() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test > in the return value check should be replaced with NULL test. > (defined(CONFIG_DEBUG_FS) make sure debugfs is enabled) > > Signed-off-by: Wei Yongjun Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 614fb02..0c992d3 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2530,12 +2530,12 @@ static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev) > ent = debugfs_create_file(debugfs_regs_names[i], > S_IFREG | S_IRUGO, root, > adev, debugfs_regs[i]); > - if (IS_ERR(ent)) { > + if (!ent) { > for (j = 0; j < i; j++) { > debugfs_remove(adev->debugfs_regs[i]); > adev->debugfs_regs[i] = NULL; > } > - return PTR_ERR(ent); > + return -ENOMEM; > } > > if (!i) > >