From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_debugfs_ring_init() Date: Tue, 19 Jul 2016 14:25:52 +0200 Message-ID: <578E1C50.2090203@amd.com> References: <1468930520-10348-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1468930520-10348-1-git-send-email-weiyj_lk@163.com> Sender: linux-kernel-owner@vger.kernel.org To: Wei Yongjun , alexander.deucher@amd.com, airlied@linux.ie, tom.stdenis@amd.com, Jammy.Zhou@amd.com, David1.Zhou@amd.com, Monk.Liu@amd.com, Jerry.Zhang@amd.com Cc: Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Am 19.07.2016 um 14:15 schrieb Wei Yongjun: > From: Wei Yongjun > > In case of error, the function debugfs_create_*() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test > in the return value check should be replaced with NULL test. > (defined(CONFIG_DEBUG_FS) make sure debugfs is enabled) > > Signed-off-by: Wei Yongjun Reviewed-by: Christian K=F6nig . There might be some more cases like this, we have probably copy&pasted=20 that code multiple times. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/d= rm/amd/amdgpu/amdgpu_ring.c > index 3b885e3..9247ae16 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > @@ -362,8 +362,8 @@ static int amdgpu_debugfs_ring_init(struct amdgpu= _device *adev, > ent =3D debugfs_create_file(name, > S_IFREG | S_IRUGO, root, > ring, &amdgpu_debugfs_ring_fops); > - if (IS_ERR(ent)) > - return PTR_ERR(ent); > + if (!ent) > + return -ENOMEM; > =20 > i_size_write(ent->d_inode, ring->ring_size + 12); > ring->ent =3D ent; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbcGSMkW (ORCPT ); Tue, 19 Jul 2016 08:40:22 -0400 Received: from mail-bl2nam02on0056.outbound.protection.outlook.com ([104.47.38.56]:62640 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753006AbcGSMkS (ORCPT ); Tue, 19 Jul 2016 08:40:18 -0400 X-Greylist: delayed 853 seconds by postgrey-1.27 at vger.kernel.org; Tue, 19 Jul 2016 08:40:18 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_debugfs_ring_init() To: Wei Yongjun , , , , , , , References: <1468930520-10348-1-git-send-email-weiyj_lk@163.com> CC: Wei Yongjun , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <578E1C50.2090203@amd.com> Date: Tue, 19 Jul 2016 14:25:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468930520-10348-1-git-send-email-weiyj_lk@163.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:b59d:82b6:5d65:c82d] X-ClientProxiedBy: AMSPR04CA0053.eurprd04.prod.outlook.com (10.242.87.171) To CY4PR12MB1302.namprd12.prod.outlook.com (10.168.168.139) X-MS-Office365-Filtering-Correlation-Id: 2e76533a-26dd-47e8-882f-08d3afcfda0e X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;2:ki5OME7CBQE1bY6btAacTT0+rPnHoVbuYChFz0XLn0VurJ+x+gKeNVbsubk0Cylk6ohcipt6w5reyC3Q+0CzgKQE7qotWN8l7aCNdngLDZiE6qTVkZ22Uf7mczXHGbkzpupRiPcCkKxjTeiTjINirNPtevUH0z0z7FnjqLnzniFI4JvcWQxXQs/Yq+J/+9Ra;3:IkpqwrkulrV/xUc1jCfVgay9t4xDh7S+FdTqJUVHlfDp5CYpVOddEnnA/4debteHtcI46CbCOZmbIi++06+4ufgQ3iEP5/fyn0DZF3u0duYuH7Hcg1gxpFBTpdph4OUE X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1302; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;25:j6AKontqq61nMpvGXe6M2uK2In5m2oXSATh8koMur/rz827jsoNDBrsdN15GGmd4AV954dE/wtWp31OnnXGU6AKf2crQ6n53ak8eV4TJsGPX+PagYWM08TCKm2BGC5+UBgqJ2CQ1PdlAkiNEtjApJJJL6LkM0r/4k+J7xwd6Sss0CrFVm2DvEBxpXZ2eDRXxX7/1tcR2+3eDnDxQP3a6wQGpGxaxgjnO+moGmT6IHjCiLT5zyrZUz18Av7WGUx3NrsiGfHgIEQzfsS7UidlpJkJcOdyXps3JDQ7hamVLzBuhxVioc4zlJgEiRdqacNlakonBLoxlrsbm3t5yHH9VGoFxPn9CQrtINbRySMaUcs4EwQWjhJcjG/DudE/ZQocm/hgJt0tIvzu0t5GtLMf8LxEJs7hFLak23OLd++fsKo2icJp8M3i7jw/mVi5GLN2Qn4HhxWhGP+o4oadZXeyTiN24ArqqY6ymBzFQNhEw1MwyQZEqsAJ8o+JImMvgHqvF5ncoovmT0506S0oN9bmUdtbjXpU8D4SMS4engKn6fKVsXNbp2v6sPRzaLXYG/bmWtJvTXg+GKGEsPcGMlmx7w98jMCktFfoqxNtPoULAm1eZKfvTexkDsJMqMqXpuirps2K8rS9n4FXCgtiYBSszym2EPAuWzxbgTameK9rlkI+h/bT87nVyuL9JVZDE+5jK/WYXUbzYWH7lppghiwEbCAfJywSPgmnRA7GQQc4x8Ks=;31:gsGQH4HfXyst5ybEvSAnG751XrWaWsJyzJTRlP+PRqWjlRGZuSUUgAJMBMa6jjGEzUgYRHq844ISnWa9MItmX2/uCEAb5O5hLvpqGXeihLeDrQoQYaiyZ6NcielT0JUpVTfBW9/JnvAVMwTSTtlCkbJqGd/BkjJaHZ78+zJCrzwUG4i1R0yZSD+XdLRo9hMr7gFvIFlfiMUmTpu3Jt9v+A== X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;20:RUiwuY3PzVGakFnc7yQNA6W+CMTNyCcopUnFYE52FXkSytq45a7PpRZFjYA+aW52cB0IH6R+I0r6NTZgtMQDLyF/5K7/MPRBobuDPDbDfFUOEx2Jyfl98gfbZGCNUiNZDdIkYtSSGa9A/oQDKWjYMEdtj2zwUPkVQUSBQeaOV3F9NOxlAkHBLvmaacQ94d9aJQok+eeUIkDK+ToKUlPUQ94aZThNCslYaj5Lx6u0BedcRogHAV5Yh64MuzrUuPAvrQVUABxvdzZCny3uPBeha5Jo+NuXNzHQeQ5UNDiVXRYB40PvDjuFXISeAkoob1LMzKz1ykIRKqqVAJKHK7K47CeeofzkKdL/3IBzXXKmP3cBW4XSR/tu7NSFZFTNftSaS7aZ9pZH48umZMZw2xiXP4U5L02TX7t8BNnv3tu2A12bdULaranZkOkEUwPVmczM4hUG+bHUo000klzM2qDK/4ZE3PpXbKwwNC7NDAbddBet+1BFRTdI/qjpsotNPW/w;4:3olW4YsnaAqplNrfHHL+aYE3KSagVOcGr2/ZeNZEu4gGRJ9ArJY+jMPNeXlcrT//TgcuRE2JBAzH7k/GtAFDkrjW1XA1iGM8GYTYpgddXwBtReipuqXp9V2HeJoYAJj2OMjCT3rcGNDAlpcSPGUdnJa/nvWgGJyOCE9CpO010QmgskBv0q0kKw/1Q3vhkSwEh1iKLzUAcTcLxVF/myDBjtP/5HTcTPVKyYFjE1sITfTGPhyV0yyvp4yT9LTCSaFtjF1aaK8zeoaaULqW+s1WvwZ5w9efaTqnJTPDB+lp3oo7P1mJXa9dU25lipNaQCJquGTPcTC86jFKin7ZYUa6UIliaV5tvuDJ3ix5MJPC7Fsd/ydNobwisSG1Er9uMOcWBjk/OeJ8DN0UbtIr3Vm9sADzKpTxZ1Mv/m2JmDEI4eg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CY4PR12MB1302;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1302; X-Forefront-PRVS: 000800954F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(2950100001)(2201001)(65816999)(50986999)(64126003)(54356999)(87266999)(4326007)(7736002)(83506001)(76176999)(305945005)(68736007)(97736004)(59896002)(7846002)(101416001)(1706002)(92566002)(47776003)(65806001)(86362001)(81156014)(4001350100001)(65956001)(81166006)(586003)(36756003)(42186005)(23746002)(105586002)(50466002)(2870700001)(189998001)(8676002)(80316001)(33656002)(6116002)(2906002)(5001770100001)(77096005)(106356001)(19580405001)(19580395003)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1302;H:[IPv6:2a02:908:1251:7981:b59d:82b6:5d65:c82d];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1302;23:m/qjz4ssENOUSeno7+3Vnod88y8+GjBI+1F1y?= =?Windows-1252?Q?ZdbwgO0W2VyZN5tuotr6/znUYksGRxMALiSVMtQmu+p19wVCJwI9VTSl?= =?Windows-1252?Q?msYEKU94l42DVV01wNiKR02k0QyhtRKIj75IJ2ibfDCVn61zmHdCUDBW?= =?Windows-1252?Q?xu7/5lB34rygsZJSiejnCto9RnkqDWaqOTews7cqSM9jyrhvyAeivNdQ?= =?Windows-1252?Q?Hje1C8faJEIW54lOBZ1Wm6TDHezZeR9aHfWacCRrs8xzzf7v4NdNf4yV?= =?Windows-1252?Q?mSPdVdLG1Y8XQvtbBBh7sjm0yx+NY16ZoEmTDh11BSk/zfzg/iwObGIk?= =?Windows-1252?Q?3r+e3iiuQCv7X64gqF2wcmS34MiGjhJ5TF109x+wMVgJhvcj5VtHk5i6?= =?Windows-1252?Q?jSs/yo1VMJTPaBaMcCSDHBcK1PA7jm2O7ZhNm4WmZzwUb/MIPDC/shox?= =?Windows-1252?Q?8abqjtm+fIrLJIVVSXXQ/boGkguBK+QQWZr3+NbghMBr/t2KkZmI9Zdb?= =?Windows-1252?Q?z+gB4GVA839JSYTXmaXxze3XOgmWIWRCvjguq6iew2Z3HPgvXTqOd112?= =?Windows-1252?Q?VHFqYwpxyOdIQ2OXM3715ZvQmbeBqN+90n3YgY3Vie9TmKmo8r8PB5R3?= =?Windows-1252?Q?OC5/6fMT5BcaMhmnnpIvseosV0r21v1PJs9zrIKoetsTH1+cy0Gz3Gcc?= =?Windows-1252?Q?6hNbl/72ti1jucq4ppDehD4an6OlinHVOyvRUKGZDQw42/Fi+QHQx2us?= =?Windows-1252?Q?63Yk7PedZJ5+HLR6tGvx5rLXmEkjMWq0mO7jp1RfjY0K2Zvh+HcQAzK8?= =?Windows-1252?Q?WOLGTQsAOOgH/RAZ2USpSoUns2E8EjEgbpuGwDfUzxJEEBp0WF/X5SlS?= =?Windows-1252?Q?V8EnKMCOnPtHGfgJFhrrd0ogzUpxd9RzTIPXsmhTlA+2s+x1W1oqWtdU?= =?Windows-1252?Q?sGb1Al69ZhtW91DB6K6hnM6w35ntt5DhN1o2mYuLxXyZ0cEK7adw3+q2?= =?Windows-1252?Q?dSK80pkPZXpTgxBmEXbaW0TetS0PbJLQCg8itrWyT3gawlkumFko5puC?= =?Windows-1252?Q?YhxVCtM9sooaMl0gmGQJgCHgOoJkaNmB0FAYi6zHREmmOUpZYF7OT40C?= =?Windows-1252?Q?eIS1bwkhcd7oLcFeRamUIPcO3K28m9W/uRD01hCQIP2RyDZe1oPGYoSU?= =?Windows-1252?Q?bWtPtJoQx7dRLlT3oFuvTiJ1qigdUO3aYrHsnOiFS2+fX0i4i/03kmh+?= =?Windows-1252?Q?zMCQvQlwjFVO7cvrrFWCBM55aWNAkdc//IkSBAEAcawWpXZQHjatwfAL?= =?Windows-1252?Q?9ADHDP4Ibpts/XGZGK86HfnmbhbIDQqqiICvIGOuyGp7xx5ZWY+Gn50n?= =?Windows-1252?Q?p3wBnhIroZn?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;6:UoJp3upTc18qmgAbLc0VTCnzbSGYeWj8vtK+oMFAmuzph9h5uKTPQrmX932IItp8r+/GY4z9w7bLYcXo8343Mh4EuJ+8PGUPHotj70it3ZDliDuhqH5w4CuzX9fdc8AOehtGtXnJd5CbTsmQsr0YLnH77ZAG5VbHjmhppj1Nd76+OA/D3i1EYY70D5jnfONfAmHiN8uKxDkTg9jrVTKooBXSLOdi8iRWOr25F7Xj/G0tzmj1jsmMnsx/+nGAoX9hsZbsk8jDXe1zubZo/lvbRnM5RCWOE1nOXXcoUZiWoyzeeYZ3B3nIl+UvSlJ2qovLLyq34qRt4jZml6ORldyvvw==;5:3GgoB7Du/CiUsNQIB/8clpYSx4/6PAVNT+LAWL4pa++PZSaILq5/HoP5+1kJ3vOoWZ9YYgbeYDO7nPfRnAZDV0aaWcW5fXQLjttZ5r1UwIdTBmLZ2vMb6fU9BHbBydULdIrRIoy998NFfJ6/m8bO9w==;24:fg31XMInnEV5yUbzJ6ABxjMo1O6f3tprMFL0ONktr8SbSuSZ09zT6FPhDzBGoiyZ40GpxlqiE1CQa1B//V81HzfKWNgAxgnHPpBDXAoRKy0=;7:J2TRq0+S83tf6CfsV7ms/K6+tp1zNq4UmWisIVkXBeTN16Zc9TjuKVWRELFk+B/drZi8yjnKwVkumUgcAuF/2ghZOOF8wEKtvMakAuhHzxhPVqUP/8R5I8AkCTCwiQErLbB5iXzK4/WzNGjJTkri6mfaOzbsi6reqPgNt2EisCI3nTPFTyaodx3NHOskoYfVT2KtUkC5tVCZq+3EolIYWnyjiBQh5SDW1+8qV6Wak+0EEeU7c59o9wWBrGNtj9b/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;20:M/BoDUnIi/5NyFwwCt+igTq0SwB1p+DJ2MDdRRGmGwgPECFnSzLBHy1aiwYKgR8WUAOtQMx1c2on5G0QjUtTs4fXqxPcgUIJ7xs0tBoV0fEeLv6CpZ6swzI5Z/hrtcRewff++M2N6lULP/XtmYpnPBgzGZYmN8b30tK28n+SuJBVzUQHR8bO8X/dl/VVpzPLF3UHxc018F65MhmpL7YuaDvk9uslmPSIjoAC6El5uQaHy2Hd4h3evSuSGOVQF/1G X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2016 12:26:01.9820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1302 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.07.2016 um 14:15 schrieb Wei Yongjun: > From: Wei Yongjun > > In case of error, the function debugfs_create_*() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test > in the return value check should be replaced with NULL test. > (defined(CONFIG_DEBUG_FS) make sure debugfs is enabled) > > Signed-off-by: Wei Yongjun Reviewed-by: Christian König . There might be some more cases like this, we have probably copy&pasted that code multiple times. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > index 3b885e3..9247ae16 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > @@ -362,8 +362,8 @@ static int amdgpu_debugfs_ring_init(struct amdgpu_device *adev, > ent = debugfs_create_file(name, > S_IFREG | S_IRUGO, root, > ring, &amdgpu_debugfs_ring_fops); > - if (IS_ERR(ent)) > - return PTR_ERR(ent); > + if (!ent) > + return -ENOMEM; > > i_size_write(ent->d_inode, ring->ring_size + 12); > ring->ent = ent; > >