From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_ttm_debugfs_init() Date: Tue, 19 Jul 2016 14:26:32 +0200 Message-ID: <578E1C78.2000502@amd.com> References: <1468930534-10432-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0076.outbound.protection.outlook.com [104.47.33.76]) by gabe.freedesktop.org (Postfix) with ESMTPS id B83D66E68C for ; Tue, 19 Jul 2016 12:26:49 +0000 (UTC) In-Reply-To: <1468930534-10432-1-git-send-email-weiyj_lk@163.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wei Yongjun , alexander.deucher@amd.com, airlied@linux.ie, David1.Zhou@amd.com, Felix.Kuehling@amd.com, Jammy.Zhou@amd.com Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMTkuMDcuMjAxNiB1bSAxNDoxNSBzY2hyaWViIFdlaSBZb25nanVuOgo+IEZyb206IFdlaSBZ b25nanVuIDx5b25nanVuX3dlaUB0cmVuZG1pY3JvLmNvbS5jbj4KPgo+IEluIGNhc2Ugb2YgZXJy b3IsIHRoZSBmdW5jdGlvbiBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCkgcmV0dXJucyBOVUxMCj4gcG9p bnRlciBub3QgRVJSX1BUUigpIGlmIGRlYnVnZnMgaXMgZW5hYmxlZC4gVGhlIElTX0VSUigpIHRl c3QKPiBpbiB0aGUgcmV0dXJuIHZhbHVlIGNoZWNrIHNob3VsZCBiZSByZXBsYWNlZCB3aXRoIE5V TEwgdGVzdC4KPiAoZGVmaW5lZChDT05GSUdfREVCVUdfRlMpIG1ha2Ugc3VyZSBkZWJ1Z2ZzIGlz IGVuYWJsZWQpCj4KPiBTaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1biA8eW9uZ2p1bl93ZWlAdHJl bmRtaWNyby5jb20uY24+CgpSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFu LmtvZW5pZ0BhbWQuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV90dG0uYyB8IDggKysrKy0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0 bS5jCj4gaW5kZXggYjc3NDJlNi4uOGM1NjllYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdHRtLmMKPiBAQCAtMTM0NSwxNiArMTM0NSwxNiBAQCBzdGF0aWMgaW50IGFt ZGdwdV90dG1fZGVidWdmc19pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgCj4g ICAJZW50ID0gZGVidWdmc19jcmVhdGVfZmlsZSgiYW1kZ3B1X3ZyYW0iLCBTX0lGUkVHIHwgU19J UlVHTywgcm9vdCwKPiAgIAkJCQkgIGFkZXYsICZhbWRncHVfdHRtX3ZyYW1fZm9wcyk7Cj4gLQlp ZiAoSVNfRVJSKGVudCkpCj4gLQkJcmV0dXJuIFBUUl9FUlIoZW50KTsKPiArCWlmICghZW50KQo+ ICsJCXJldHVybiAtRU5PTUVNOwo+ICAgCWlfc2l6ZV93cml0ZShlbnQtPmRfaW5vZGUsIGFkZXYt Pm1jLm1jX3ZyYW1fc2l6ZSk7Cj4gICAJYWRldi0+bW1hbi52cmFtID0gZW50Owo+ICAgCj4gICAj aWZkZWYgQ09ORklHX0RSTV9BTURHUFVfR0FSVF9ERUJVR0ZTCj4gICAJZW50ID0gZGVidWdmc19j cmVhdGVfZmlsZSgiYW1kZ3B1X2d0dCIsIFNfSUZSRUcgfCBTX0lSVUdPLCByb290LAo+ICAgCQkJ CSAgYWRldiwgJmFtZGdwdV90dG1fZ3R0X2ZvcHMpOwo+IC0JaWYgKElTX0VSUihlbnQpKQo+IC0J CXJldHVybiBQVFJfRVJSKGVudCk7Cj4gKwlpZiAoIWVudCkKPiArCQlyZXR1cm4gLUVOT01FTTsK PiAgIAlpX3NpemVfd3JpdGUoZW50LT5kX2lub2RlLCBhZGV2LT5tYy5ndHRfc2l6ZSk7Cj4gICAJ YWRldi0+bW1hbi5ndHQgPSBlbnQ7Cj4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbcGSMmZ (ORCPT ); Tue, 19 Jul 2016 08:42:25 -0400 Received: from mail-sn1nam02on0043.outbound.protection.outlook.com ([104.47.36.43]:9338 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753085AbcGSMmI (ORCPT ); Tue, 19 Jul 2016 08:42:08 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_ttm_debugfs_init() To: Wei Yongjun , , , , , References: <1468930534-10432-1-git-send-email-weiyj_lk@163.com> CC: Wei Yongjun , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <578E1C78.2000502@amd.com> Date: Tue, 19 Jul 2016 14:26:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468930534-10432-1-git-send-email-weiyj_lk@163.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:b59d:82b6:5d65:c82d] X-ClientProxiedBy: AMSPR04CA0033.eurprd04.prod.outlook.com (10.242.87.151) To MWHPR12MB1311.namprd12.prod.outlook.com (10.169.205.136) X-MS-Office365-Filtering-Correlation-Id: eb832884-85a9-4dc6-8db0-08d3afcff2d2 X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1311;2:II8xElPm6kWPRgXpQxXqyVQjiuoEKHx2XsWz7fEc0Rs2R7H49ElkvcVTmhfxHFyGfLh9KFYkZPEQz3TxTf7iEIE+UxNQN4ADtch82yNTK6yrBWhKWEynFwYVPSz6U0/FgsWku2oMjsvHkBi4muVQUsCrhtAIeH9vAgggcHChPjhDGxCHKjhx05YJCKioeGqY;3:HYBSOGduWP9RvF3vebiN5gNMhk9QpvHM4vPGOjfAciBzWWduPKCVi/rYm+6AeMUje3PkG74zPP92LNG7RyHAm8pZJ55NbLWx/zJXSmycOZoCQtBA5LATG1Y8BQvvivAn X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1311; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1311;25:CqDgf0kmgxtWjstR64XKFlvw1N92BW7xESI4eu3OaWsBpFvj+LhesU5wKKnJ1png8aDM0MwwfJN6sw+hLnU/p1Fx3/ruNerulsHwcraTzjb24ZKAr0U7DWeYA45wTiXlbkiNk3ffFU56X1XuBu+cBPMO+Mz4fcvkpCR2CID+LHzn4WLogrFynszl8MRtYiUk5FWdM/1QIhHO67pUb9e1WM84sSIZ+dEqFz44yEm3shI2laXJe5Hwor5ZE5bBmgNXJCcUnIiRF3MbU3wpa2yLUk3JeVfW0OR9IUl2x8IMJvQ5Jwi5dkfZibuCaZkju9oJRgxxvTFL17Xvhj3+hWaT+4FaHV21JohqtnDwqyqf4esZdhCe5Iza8jeQ3e2nalRXe2xke4CsLIj+eD1OFGBWWgAWIoh+T7lR4Lg/5lJoT0QvOTZEIYDsyK/h9U6pdbqgrFOHVOQaqkeFXsU/x84rbTPCFu+IwsF9Za1mpR1MWyagQZkJdXCJtXK5NvdLrHRVc/PNSXhNF+NfaN/T40yW/x/uDsojCruMKjT/VVTyCHv59g6b7PcmHYsVn1lIirpQiMnKI69Z76tD0wZ2O43sIiyc5CeZBuhoF5r5oYuOunwwW63/rqUEhtX2XX+lDtC9xt2Uz+oN4I+kaQIEK8WyPvGTQTUYssPblmfpz/gaXhjxPChWkeMoWjct0YR98vLa4/Z7VkDnibutxXu/nj0QFOWcAzs7ZzFXJrnb5X8sUxg=;31:4EmGyKWoS7bMoGmMa4IUk+Z6Dajmvt2VbEtLtPRlLzljJGRJT4VB5A+aQIFbqMf7/itp8LgOURQw2eiUxiptD8YAcpxJ0ACw8eZb4xEROURD5h1RAmsqhAJKDTbPR4ZCclP3U6ZvADBfu0K43YgsIQydHtxhBMcVhuzCqO8gFvH5isu6lurNuwaUTEDOui+1e6Lk1uvKLFhDRYrH4G69IQ== X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1311;20:GX10MFOuzhQIItiloXJu6b9HHrE6Osek1RbQNYzFNl1v7HiaGKJRf2/k9RSWVaf6DDTP3AGM5L903ZVx1bk5e2ZSoAC6Yx4wIxqqrTQuCbZmjvFOcj9BavI8ppziZXfzMfOoG7v94lDS0z2yA7ZHmdAnwlC3gRN4IHigsoSPfshWn9L1PSd0EC4IO1CcybGMawG0l3MSoCtIt/h8LiGXwAfBhLTKIlrZaBj3vUW9wyivf4BpVtlmsHtBeUFZHuHtbbTIUeJcWcMV+GGvUGm5qACpaBPgKc1WNtfiXLmcdJK/DQkXqSQbV8u8GZTjTZeUx3EubDls+c2qn89TaY1UMZe8TX6v2TQvZyit8C8eUSnC7oPOIAJozWrjw1WAsxKI5+Fr3QS9MuXv7+yblbL9FvU2bf6h7YmNIwVtpnEOJS1RkCb4UGuGLj/mu63+wtvAYa5ShW8EnYclH1usu47bfDx+Bjg92TkVyljrzYsmkIfjKTT2RlnzqSgy82Lc74VQ;4:D0HC/vQuCvFASpiMDebiHmFcCphmyCz2FxuV/g90PCr4isKLcStv5bMuYyEjo2WcPdm9W6tejcnarL1zyx+6hDmHTxyZpWN8qIBTOy1pw3J1ULUV/Irz8RMhZQ/MLh/2PWmZdAfU1w65okNo4GQhtC/rlv0Pg88BuDk8aNUYmn7l56ydYLJQ7CDPgiock+Bu6cFykT8JUFx5Sy93sWvvsnTWU5CoQh4+D4vH7PjPtYqU18TmtOxivQIgXr385Y5lyX0MQ9tkTQVt2E+MT4aROXdctA3pvRtJkxtjaceegiq/c/uhV7lvxrHfwHc0pM9ZlbTxXQbcDvUmpbqSLlLHVuBpwyF5YaptgnOHXbajmuMgtVdO7kmcWztbNeFjcZtsL0pIkwfZC2lQMUkmUlFef5jhre1sn2ot0KZJD42J42s= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:MWHPR12MB1311;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1311; X-Forefront-PRVS: 000800954F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(68736007)(586003)(189998001)(59896002)(86362001)(105586002)(33656002)(2870700001)(1706002)(23746002)(19580405001)(19580395003)(80316001)(54356999)(87266999)(76176999)(50986999)(42186005)(2950100001)(83506001)(81166006)(81156014)(92566002)(8676002)(36756003)(5001770100001)(97736004)(47776003)(101416001)(2906002)(6116002)(65956001)(2201001)(64126003)(77096005)(65806001)(65816999)(4001350100001)(305945005)(7736002)(50466002)(7846002)(106356001)(4326007)(3826002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1311;H:[IPv6:2a02:908:1251:7981:b59d:82b6:5d65:c82d];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR12MB1311;23:/zufj8XTWrntrbRrgBf/MlHRdNEukmQ8AYEN7?= =?Windows-1252?Q?VCeLdjffCYTzAoBmqdTbKYorPC0TBjvbcdBr4q9ceEaDHGQHcX//WL7m?= =?Windows-1252?Q?VDVHPjSblSEG3IyFWUATdiHhokdWYXb4M6Unwtv90DhHDy+0SRwgh4lr?= =?Windows-1252?Q?T1aOWgY5pffyu92w0yIeY/coTl121kcWTbziDGgUYB9Uf1yzLABIpBdB?= =?Windows-1252?Q?xoveDNUTLKRsBfeNPK4LOjHhv4LWtIgFSsUyCoK7j89Dqiw7hwxkhfl3?= =?Windows-1252?Q?sR4T/7SRGxIL0NxFwe7nqaXsrnVtAfzASnQb6LK84+4Jn8Y/MUxGH0Mj?= =?Windows-1252?Q?gcz9Nhs0uXzvNpfJ+MVH5dYnkc/qFvfhMtRitF32gVuBuTGK9+NG2+uf?= =?Windows-1252?Q?qstcK6WYh6lY7iqpPQNq/O9BTvk7J/Z2cs/sTIYLEibmyqwafC/deaWz?= =?Windows-1252?Q?Nsg5EyakoFNLEDq3pfWc8wgr0qyDyyfS+k+F9ChXBJckW2WdxWkn83Tk?= =?Windows-1252?Q?Yj43O4OW5rd/9SXd9mdX1i1BpIf4OL39BTZ1npKQz1RZwKDgEsRds7Po?= =?Windows-1252?Q?7nhcxMuqnVYul+QJSYIA/SmNd1n2GGsyt6uF0jYOyyiBD8RN5OvkjNSV?= =?Windows-1252?Q?6f/BYJLKo3jEBQGdeUsdrQHDQnbzssYqWroOPeANtOj5e2AoRNeGXoOB?= =?Windows-1252?Q?XyfnVIEKlLxrfnowQoS5Zc7pIH0YJIACbQPcNjDG0Ip6pPq93QOq0tLs?= =?Windows-1252?Q?hU48ynHIOt65vwoHafddzWybVKKhpe8zWp2w6yonyJxJg8DOXb+ZBd7v?= =?Windows-1252?Q?PMm2nJbDhM6Lb/SjXXY6drkhx4e8BMrDPqnV+qCcdlcNFi0Sdfe5t8YI?= =?Windows-1252?Q?9d+OSRQUXbT1M2zTQkuxNXKOR+9tDObVGKoU+wod5Y0kskOw3MQ4RVyH?= =?Windows-1252?Q?WUVcUc6F6XXhV+O1UlTKMumicwKzIVfeg8tuvtFH5F7jdiHvcuL0XBBi?= =?Windows-1252?Q?9KeBTRuH0sKAVBoOybvCUbO/tsKhbaTLU3kbwXT2k+6d5CIkFpQASgpi?= =?Windows-1252?Q?J6HeNmRBPWnnW7qWDxFn+VydDq40CNjSabWMh88foTzUYQh8lS4k/otN?= =?Windows-1252?Q?89QqMyfmA5IfqQu6hDY5wnilft/W1ZbYFsSuzKOnfLV07Ra2L+8Wsufq?= =?Windows-1252?Q?yQ5iYZynGr9PLhgEiLeOvocgQeENm9gr2CWADxFwsxwnxNAdHSmiTkfh?= =?Windows-1252?Q?jDY2H6cN9UuqToucCA3XJCIvDaBtq/qp/o2fqpYO0M3nIi6012uGtSug?= =?Windows-1252?Q?vilJaIb60XG4i9BbrXWtgO+TKmfZKGMT2AgZQ3kGb67bt6G/J72ln8LO?= =?Windows-1252?Q?3TcO6AXvLRH?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1311;6:Rsuj6ISo3r3r7Q8QEBncbvgl/8ogO13CyLmrLMkQDdt50cO4x61oimNKZDVC6Ux8JltZ8Tw1q5iW7XtMCjqEX/4FJCo3/t9I8Q1lkEQCMJBDLFWz8QY6K/TFpcK6QPZ6ObKOm3JbXNuGE0APWp8Eh2RvuYrKIyzTEPA3rzGmTiiB2YX+f7oJY1JhsvoGi7gS7YpGA7bT2tUqv0TRcQR02GvH+FxijbQC+jgoHS2Ruh/riM7E6wtcHRcDzTQjGCR+HKDK2ipDX+7LBHtiOL9TaRFsvJQ2zqH+PxTAjg5rvN7GOB6/6u8MK0kA0XXOc98zEXIOmBRY73Hw4s+DZEv6kw==;5:EqQXazMMe62Rk+jkL7Ufqwk0H5drf/P3UmXpjZLVIJpQfyd+l2MB1t85uH5NtPOf/PjFAtssIkqPjwGiYqItQSFC5dCJHTwTlfBtIR0NZ4sokzbgIquAuCVPxUtxoWJGjEJX3HMJ+rtkKhwjRCZ7Xw==;24:uLmyHy15re1sS5PhAFyZgk3xZzkCKgBZPL0O4wZaUm0CfFje0IFEu8uJxutJ/FJcDBeNFeUhT6mZcy0NRO5IeCxu90sVvk4yMe+yxoJ4ji0=;7:AViXeAq8Vt+CqDQrnZdusQaDbDCqYH4unlI6nZW1shjFqgMT5jwBcqJA8as4AYWBh7pKFSjoGMfxLmAY2+IS1rRPtc2pY3Lwqn5mraIU3pAksL8kmRWlrY66ihaQ5ejnCkuFqoTLHSOYWkrG47fRcOTNW7tnK8LwpMhZ3aGCspxENVyskXzB/l2pLFxLQMTecWwM4rXr/ohZ0y8prLGrq7AftgWNuwZLswQsa2LmsxTlLXkUFl77fyBYSZaVOSQn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1311;20:RQ9o/qDTErkT2wSgFI1wsBMpYIqqgzmAW6sQaOti+GF3EvibLsA7iG6uG93aqkqYs3/3Y1H9xrCY6YvVwL7X7mJ+Swn6pzH6jMsOaKPVA8lp6F8ceSyFPu8LP62SBT+5UXXAxSpiZU4XqWcgW1JrucRNcMXrNcDWrCbNT0xHDCAHaIIIOgFY4Nqcs4hJ75R/SsXGf+VEWj3G3nkJsHqvUOacQJ2QI6iHx1acKyDTT9/lyuF2xcRtoM3vVJZPLy9F X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2016 12:26:43.7051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1311 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.07.2016 um 14:15 schrieb Wei Yongjun: > From: Wei Yongjun > > In case of error, the function debugfs_create_file() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test > in the return value check should be replaced with NULL test. > (defined(CONFIG_DEBUG_FS) make sure debugfs is enabled) > > Signed-off-by: Wei Yongjun Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index b7742e6..8c569ea 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -1345,16 +1345,16 @@ static int amdgpu_ttm_debugfs_init(struct amdgpu_device *adev) > > ent = debugfs_create_file("amdgpu_vram", S_IFREG | S_IRUGO, root, > adev, &amdgpu_ttm_vram_fops); > - if (IS_ERR(ent)) > - return PTR_ERR(ent); > + if (!ent) > + return -ENOMEM; > i_size_write(ent->d_inode, adev->mc.mc_vram_size); > adev->mman.vram = ent; > > #ifdef CONFIG_DRM_AMDGPU_GART_DEBUGFS > ent = debugfs_create_file("amdgpu_gtt", S_IFREG | S_IRUGO, root, > adev, &amdgpu_ttm_gtt_fops); > - if (IS_ERR(ent)) > - return PTR_ERR(ent); > + if (!ent) > + return -ENOMEM; > i_size_write(ent->d_inode, adev->mc.gtt_size); > adev->mman.gtt = ent; > >