From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] mk: fix FreeBSD build
Date: Tue, 19 Jul 2016 16:04:12 +0100 [thread overview]
Message-ID: <578E416C.7020306@intel.com> (raw)
In-Reply-To: <CAATJJ0LaBF2Q=KMGzBFR7M2=j8JgwWfJ803b9tmbMiYUEDriwA@mail.gmail.com>
On 7/19/2016 3:30 PM, Christian Ehrhardt wrote:
> Hi,
> the order changed, but IMHO actually it improved.
> Things are now at the place they were before, but with the overwriting
> config value that came later - that is the best of both worlds.
Agreed, this is a good solution. Also fixes multiple copy of file
comment issue ...
>
> Tested a few config runs pre/post patch and compared them sorted (equal)
> and unsorted - now configs slotted in where they belong.
> Thanks for updating Sergio
>
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com
> <mailto:christian.ehrhardt@canonical.com>>
>
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd
>
next prev parent reply other threads:[~2016-07-19 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 13:11 [PATCH] mk: fix FreeBSD build Sergio Gonzalez Monroy
2016-07-18 13:25 ` Thomas Monjalon
2016-07-18 13:39 ` Sergio Gonzalez Monroy
2016-07-18 13:54 ` Christian Ehrhardt
2016-07-18 14:06 ` Sergio Gonzalez Monroy
2016-07-18 14:07 ` Thomas Monjalon
2016-07-18 14:51 ` Sergio Gonzalez Monroy
2016-07-18 16:06 ` [PATCH v2] " Sergio Gonzalez Monroy
2016-07-19 10:32 ` Ferruh Yigit
2016-07-19 11:01 ` Christian Ehrhardt
2016-07-19 11:40 ` Sergio Gonzalez Monroy
2016-07-19 13:40 ` [PATCH v3] " Sergio Gonzalez Monroy
2016-07-19 14:30 ` Christian Ehrhardt
2016-07-19 15:04 ` Ferruh Yigit [this message]
2016-07-21 8:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578E416C.7020306@intel.com \
--to=ferruh.yigit@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.