From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Kiss Subject: Re: [PATCH] mempool: fix lack of free() registration Date: Tue, 19 Jul 2016 17:17:20 +0100 Message-ID: <578E5290.3070100@linaro.org> References: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: David Hunt , Thomas Monjalon To: Olivier Matz , Zoltan Kiss , dev@dpdk.org Return-path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id C4DB33B5 for ; Tue, 19 Jul 2016 18:17:22 +0200 (CEST) Received: by mail-lf0-f49.google.com with SMTP id b199so18855342lfe.0 for ; Tue, 19 Jul 2016 09:17:22 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/07/16 16:26, Olivier Matz wrote: > Hi Zoltan, > > I ran ./scripts/check-git-log.sh on your patch, showing some minor > styling issues: Thanks, do you want me to resend it, or could Thomas fix them upon commiting? > > On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >> [PATCH] mempool: fix lack of free() registration > > "()" should be removed > >> The new mempool handler interface forgets to register the free() function >> of the ops. Introduced in this patch: >> >> 449c49b9 mempool: support handler operations > > The format should be: > Fixes: 449c49b93a6b ("mempool: support handler operations") > > >> >> Signed-off-by: Zoltan Kiss >> --- >> lib/librte_mempool/rte_mempool_ops.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c >> index fd0b64c..5f24de2 100644 >> --- a/lib/librte_mempool/rte_mempool_ops.c >> +++ b/lib/librte_mempool/rte_mempool_ops.c >> @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h) >> ops = &rte_mempool_ops_table.ops[ops_index]; >> snprintf(ops->name, sizeof(ops->name), "%s", h->name); >> ops->alloc = h->alloc; >> + ops->free = h->free; >> ops->enqueue = h->enqueue; >> ops->dequeue = h->dequeue; >> ops->get_count = h->get_count; >> > > Apart from that: > Acked-by: Olivier Matz > > +CC Thomas, I think it should be included in 16.07. > > Thanks! >