From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mengdong Lin Subject: Re: [PATCH v2 0/3] Remove support for SNDRV_CTL_ELEM_ACCESS_USER & minor fix Date: Wed, 20 Jul 2016 12:51:31 +0800 Message-ID: <578F0353.20907@linux.intel.com> References: <578EFE0C.1010205@sakamocchi.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by alsa0.perex.cz (Postfix) with ESMTP id 6527E265892 for ; Wed, 20 Jul 2016 06:46:24 +0200 (CEST) In-Reply-To: <578EFE0C.1010205@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto , alsa-devel@alsa-project.org, broonie@kernel.org Cc: tiwai@suse.de, mengdong.lin@intel.com, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org On 07/20/2016 12:29 PM, Takashi Sakamoto wrote: > Hi, > > On Jul 20 2016 10:52, mengdong.lin@linux.intel.com wrote: >> From: Mengdong Lin >> >> There is no ABI change in this series. >> >> Remove support for control flag SNDRV_CTL_ELEM_ACCESS_USER as Takashi >> Sakamoto suggested. Also fix 2 compiler warnings and add check before >> string cpy. >> >> History: >> v2: Revise commit messages. >> >> Mengdong Lin (3): >> topology: Remove support for control flag SNDRV_CTL_ELEM_ACCESS_USER >> topology: Add ATTRIBUTE_UNUSED for unused parameters to fix compiler >> warning >> topology: Check address and length before string copy >> >> src/topology/ctl.c | 1 - >> src/topology/pcm.c | 8 ++++---- >> src/topology/tplg_local.h | 3 +++ >> 3 files changed, 7 insertions(+), 5 deletions(-) > > Reviewed-by: Takashi Sakamoto > > But I believe that we can seek better ways for the purpose of third > patch. For example, changing prototype of the function to return error > code might help callers to handle errors appropriately. > > Anyway, thanks for the first patch. > The 3rd patch is to reduce checking on some optional fields elsewhere. We could drop this patch if we add check before calling elem_copy_text() and it will bring more code. Thanks Mengdong