From: Arun Siluvery <arun.siluvery@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gen9: Add WaDisableGatherAtSetShaderCommonSlice
Date: Wed, 20 Jul 2016 11:42:45 +0100 [thread overview]
Message-ID: <578F55A5.4070507@linux.intel.com> (raw)
In-Reply-To: <1466088299-4792-1-git-send-email-mika.kuoppala@intel.com>
On 16/06/2016 15:44, Mika Kuoppala wrote:
> Add WaDisableGatherAtSetShaderCommonSlice for all gen9 as stated
> by bspec.
>
> References: HSD#2135817
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 1 +
> drivers/gpu/drm/i915/intel_lrc.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index d229a83ad70a..ff87d0b58d91 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -6117,6 +6117,7 @@ enum skl_disp_power_wells {
> # define GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC ((1<<10) | (1<<26))
> # define GEN9_RHWO_OPTIMIZATION_DISABLE (1<<14)
> #define COMMON_SLICE_CHICKEN2 _MMIO(0x7014)
> +# define GEN9_DISABLE_GATHER_AT_SET_SHADER_COMMON_SLICE (1<<12)
> # define GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION (1<<8)
> # define GEN8_CSC2_SBE_VUE_CACHE_CONSERVATIVE (1<<0)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 4fad8303648e..f4c7f7e6d523 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1285,6 +1285,13 @@ static int gen9_init_perctx_bb(struct intel_engine_cs *engine,
> {
> uint32_t index = wa_ctx_start(wa_ctx, *offset, CACHELINE_DWORDS);
>
> + /* WaDisableGatherAtSetShaderCommonSlice:skl,bxt,kbl */
> + wa_ctx_emit(batch, index, MI_LOAD_REGISTER_IMM(1));
> + wa_ctx_emit_reg(batch, index, COMMON_SLICE_CHICKEN2);
> + wa_ctx_emit(batch, index, _MASKED_BIT_DISABLE(
> + GEN9_DISABLE_GATHER_AT_SET_SHADER_COMMON_SLICE));
> + wa_ctx_emit(batch, index, MI_NOOP);
> +
The documentation says it is perctx wa batch but it is not correct, I
got a clarification internally and they are trying to get it corrected.
This needs to be applied in indirect context wa batch.
regards
Arun
> /* WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken:skl,bxt */
> if (IS_SKL_REVID(engine->i915, 0, SKL_REVID_B0) ||
> IS_BXT_REVID(engine->i915, 0, BXT_REVID_A1)) {
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-07-20 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 14:44 [PATCH] drm/i915/gen9: Add WaDisableGatherAtSetShaderCommonSlice Mika Kuoppala
2016-06-16 15:06 ` ✗ Ro.CI.BAT: warning for " Patchwork
2016-06-28 10:03 ` [PATCH] " Matthew Auld
2016-07-20 10:42 ` Arun Siluvery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578F55A5.4070507@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.