From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>, Jean Delvare <jdelvare@suse.com>
Cc: Thilo Cestonaro <thilo@cestona.ro>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: ftsteutates: add watchdog dependency
Date: Wed, 20 Jul 2016 06:29:25 -0700 [thread overview]
Message-ID: <578F7CB5.80803@roeck-us.net> (raw)
In-Reply-To: <20160720103809.2643157-1-arnd@arndb.de>
On 07/20/2016 03:37 AM, Arnd Bergmann wrote:
> The newly added fts "Teutates" hwmon chip contains a watchdog but fails
> to link when the watchdog subsystem is disabled:
>
> drivers/hwmon/built-in.o: In function `fts_remove':
> :(.text+0x161d8): undefined reference to `watchdog_unregister_device'
> drivers/hwmon/built-in.o: In function `fts_probe':
> :(.text+0x16cb4): undefined reference to `watchdog_register_device'
>
> This adds a Kconfig dependency in the same way that the other
> similar drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"")
Thanks - folded into original patch.
Guenter
> ---
> drivers/hwmon/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 15479eb15fa2..eaf2f916d48c 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -488,7 +488,8 @@ config SENSORS_FSCHMD
>
> config SENSORS_FTSTEUTATES
> tristate "Fujitsu Technology Solutions sensor chip Teutates"
> - depends on I2C
> + depends on I2C && WATCHDOG
> + select WATCHDOG_CORE
> help
> If you say yes here you get support for the Fujitsu Technology
> Solutions (FTS) sensor chip "Teutates" including support for
>
prev parent reply other threads:[~2016-07-20 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 10:37 [PATCH] hwmon: ftsteutates: add watchdog dependency Arnd Bergmann
2016-07-20 13:29 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578F7CB5.80803@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thilo@cestona.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.