From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPrr7-00063t-TI for qemu-devel@nongnu.org; Wed, 20 Jul 2016 09:48:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPrr3-0008E3-54 for qemu-devel@nongnu.org; Wed, 20 Jul 2016 09:48:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPrr2-0008Dq-T2 for qemu-devel@nongnu.org; Wed, 20 Jul 2016 09:48:05 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4DE0F3E2A1 for ; Wed, 20 Jul 2016 13:48:04 +0000 (UTC) References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-36-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <578F8113.40208@redhat.com> Date: Wed, 20 Jul 2016 07:48:03 -0600 MIME-Version: 1.0 In-Reply-To: <20160719085432.4572-36-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8rcvMPnQUA8LMCr8euAlko62etUqKObjC" Subject: Re: [Qemu-devel] [PATCH 35/37] tests: fix rsp leak in postcopy-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8rcvMPnQUA8LMCr8euAlko62etUqKObjC From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Message-ID: <578F8113.40208@redhat.com> Subject: Re: [Qemu-devel] [PATCH 35/37] tests: fix rsp leak in postcopy-test References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-36-marcandre.lureau@redhat.com> In-Reply-To: <20160719085432.4572-36-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 02:54 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > In all cases, even when the dict doesn't contain 'ram', the qmp respons= e > must be unref. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/postcopy-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c > index 74fa969..f6f6598 100644 > --- a/tests/postcopy-test.c > +++ b/tests/postcopy-test.c > @@ -198,8 +198,8 @@ static uint64_t get_migration_pass(void) > } else { > rsp_ram =3D qdict_get_qdict(rsp_return, "ram"); > result =3D qdict_get_try_int(rsp_ram, "dirty-sync-count", 0); > - QDECREF(rsp); > } > + QDECREF(rsp); > return result; > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8rcvMPnQUA8LMCr8euAlko62etUqKObjC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXj4ETAAoJEKeha0olJ0NqZ1AH/A6P5OA6+F7/zjOoFMXUl9PY w794HQZipYb8wyBKiYXgorYhhegPvSDOZiwReofpRmWRPTVyczCCljEBSOSNh/dE jnuVc0CdW7s/xoB1uO/y/gA4xt1r9DowI1U6zB9okftX6Ru8vXUA4tvN4JVFF2QE Sy1bLqghoq3mj8GlgUFESaS508IZMHunb1GVlFtU3jvCYtL3qov70awvPDJokEv+ 3kRDEJqnUjJ1XY/n/aFZchfxY6GdtFjPWcmgDD2V8yV7JVzkCsi2WDEEunS+F3L3 bLSWaFa3tf+WThV16s9WINBMgMC07SHwPFBq7roaQTmTfOwwLq/QPtGf69eKaRo= =jDLK -----END PGP SIGNATURE----- --8rcvMPnQUA8LMCr8euAlko62etUqKObjC--