All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v2 1/1] wandboard: fix dtb file names.
Date: Wed, 20 Jul 2016 16:52:58 +0200	[thread overview]
Message-ID: <578F904A.1060505@denx.de> (raw)
In-Reply-To: <BAY169-W5686C54AA8FD1C1589071DB9370@phx.gbl>

Hi Adam,

On 19/07/2016 19:51, Adam Duskett wrote:
>> From: festevam at gmail.com
>> Date: Tue, 19 Jul 2016 14:46:38 -0300
>> Subject: Re: [U-Boot] [v2 1/1] wandboard: fix dtb file names.
>> To: AdamDuskett at outlook.com
>> CC: u-boot at lists.denx.de; sbabic at denx.de
>>
>> On Tue, Jul 19, 2016 at 2:40 PM, Adam Duskett
> <AdamDuskett@outlook.com> wrote:
>>
>> >> I prefer to keep the current code as is.
>> > If it is left as is, then the previous version of the patch needs to be
>> > applied
>> > because the new dtb file names in kernel 4.1.15 are different.
>>
>> Then please change the name of the 4.1.15 vendor kernel dts to match
>> the one from mainline.
> 
> I did, and as per the commit message; Wolfgang Denk suggested making it
> into a 
> logic based function?  What would you like me to do?  I can just
> resubmit the old patch
> which changed the vendor names, or would you like me to follow
> Wolfgang's directions?
> 

There is something wrong in the approach. Please think that this is the
"default" environment fopr the wandboard, and this does not mean that
you have *always* to use the same environment. It is not thinkable that
anytime the kernel name (or something like this) is changed, u-boot
*code* must be changed.

More in the case of "community" boards like a wandboard, it must be
ensured that everybody can still work with it, without breaking for
small things as the DT's name the behaviour.

wandboar uses distro environment: why do not put a "boot.scr" in your
/boot directory on SD, as wandboard boots only from SD, and you
overwrite all values you want ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2016-07-20 14:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 17:23 [U-Boot] [v2 1/1] wandboard: fix dtb file names Adam Duskett
2016-07-19 17:32 ` Fabio Estevam
2016-07-19 17:40   ` Adam Duskett
2016-07-19 17:46     ` Fabio Estevam
2016-07-19 17:51       ` Adam Duskett
2016-07-20 14:52         ` Stefano Babic [this message]
2016-07-19 17:43   ` Tom Rini
2016-07-19 17:51     ` Fabio Estevam
2016-07-19 17:58       ` Adam Duskett
2016-07-19 18:05         ` Fabio Estevam
2016-07-19 18:04       ` Tom Rini
2016-07-19 17:47 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578F904A.1060505@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.