Re: [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On 07/19/2016 06:21 PM, Jeff Cody wrote:
> From: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> 
> this patch adds 'GlusterServer' related schema in qapi/block-core.json
> 
> [Jeff: minor fix-ups of comments and formatting, per patch reviews]
> 
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Message-id: 1468947453-5433-5-git-send-email-prasanna.kalever@redhat.com
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---

> +++ b/qapi/block-core.json
> @@ -1666,13 +1666,14 @@

> +##
> +# @BlockdevOptionsGluster
> +#
> +# Driver specific block device options for Gluster
> +#
> +# @volume:      name of gluster volume where VM image resides
> +#
> +# @path:        absolute path to image file in gluster volume
> +#
> +# @server:      gluster server description
> +#
> +# @debug-level: #optional libgfapi log level (default '4' which is Error)

You got one,

> +#
> +# Since: 2.7
> +##
> +{ 'struct': 'BlockdevOptionsGluster',
> +  'data': { 'volume': 'str',
> +            'path': 'str',
> +            'server': 'GlusterServer',
> +            '*debug_level': 'int' } }

but not the other instance. Can be fixed in a followup patch if the pull
request has already landed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]