All of lore.kernel.org
 help / color / mirror / Atom feed
From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting
Date: Thu, 21 Jul 2016 10:46:46 +0200	[thread overview]
Message-ID: <57908BF6.80606@denx.de> (raw)
In-Reply-To: <f2f519ad-4004-5cf7-8e5f-7adda347acf0@toradex.com>


Hi Breno, Stefan,

Am 20.07.2016 um 21:44 schrieb Stefan Agner:
> On 20.07.2016 12:34, Breno Lima wrote:
>> Commit 83fd908f28c ("dm: imx: serial: Support DTE mode when using driver
>> model") breaks the serial output for the imx boards that do not use
>> the serial driver model.
>>
>> The reason for the breakage is that it's setting UFCR_DCEDTE
>> unconditionally for the non-dm case.
> Uh yes, that wasn't intentionally and slipped through review! I meant to
> add DTE support only in the dm case. Sorry about that.
>
> Acked-by: Stefan Agner <stefan.agner@toradex.com>

Right, I apply this before sending my PR to Tom.

Best regards,
Stefano Babic

>
>> So keep the original behavior by removing UFCR_DCEDTE setting in the
>> non-dm case.
>>
>> Tested on mx7sabresd and mx6wandboard.
>>
>> Signed-off-by: Breno Lima <breno.lima@nxp.com>
>> ---
>>  drivers/serial/serial_mxc.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
>> index 1960bbc..8545714 100644
>> --- a/drivers/serial/serial_mxc.c
>> +++ b/drivers/serial/serial_mxc.c
>> @@ -151,7 +151,6 @@ static void mxc_serial_setbrg(void)
>>  	__REG(UART_PHYS + UFCR) = (RFDIV << UFCR_RFDIV_SHF)
>>  		| (TXTL << UFCR_TXTL_SHF)
>>  		| (RXTL << UFCR_RXTL_SHF);
>> -	__REG(UART_PHYS + UFCR) |= UFCR_DCEDTE;
>>  	__REG(UART_PHYS + UBIR) = 0xf;
>>  	__REG(UART_PHYS + UBMR) = clk / (2 * gd->baudrate);
>>  

  reply	other threads:[~2016-07-21  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 19:34 [U-Boot] [PATCH] serial_mxc: Remove unconditional DCE setting Breno Lima
2016-07-20 19:44 ` Stefan Agner
2016-07-21  8:46   ` stefano babic [this message]
2016-07-20 20:19 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57908BF6.80606@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.