diff for duplicates of <579094EB.5030207@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 0660510..6f308d5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -98,7 +98,7 @@ On 20/07/16 04:58, David Matlack wrote: >> +static void grow_halt_poll_ns(struct kvmppc_vcore *vc) >> +{ >> + /* 10us base */ ->> + if (vc->halt_poll_ns = 0 && halt_poll_ns_grow) +>> + if (vc->halt_poll_ns == 0 && halt_poll_ns_grow) >> + vc->halt_poll_ns = 10000; >> + else >> + vc->halt_poll_ns *= halt_poll_ns_grow; @@ -109,7 +109,7 @@ On 20/07/16 04:58, David Matlack wrote: >> + >> +static void shrink_halt_poll_ns(struct kvmppc_vcore *vc) >> +{ ->> + if (halt_poll_ns_shrink = 0) +>> + if (halt_poll_ns_shrink == 0) >> + vc->halt_poll_ns = 0; >> + else >> + vc->halt_poll_ns /= halt_poll_ns_shrink; @@ -170,7 +170,7 @@ On 20/07/16 04:58, David Matlack wrote: >> + cur = ktime_get(); >> + } while (ktime_before(cur, stop)); > The generic halt-polling implementation only polls if there are no -> other threads waiting to run (single_task_running() = 1). Should/Can +> other threads waiting to run (single_task_running() == 1). Should/Can > we do the same here? Thanks for catching that. diff --git a/a/content_digest b/N1/content_digest index 236bc81..7bfce1f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0CALzav=dKcw+iRZ-O7HrDd3K1kagOFvGF3ALiJKnjdThvhbhu=g@mail.gmail.com\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [PATCH V4 3/5] kvm/ppc/book3s_hv: Implement halt polling in the kvm_hv kernel module\0" - "Date\0Thu, 21 Jul 2016 09:24:59 +0000\0" + "Date\0Thu, 21 Jul 2016 19:24:59 +1000\0" "To\0David Matlack <dmatlack@google.com>\0" "Cc\0linuxppc-dev@lists.ozlabs.org" kvm-ppc@vger.kernel.org @@ -117,7 +117,7 @@ ">> +static void grow_halt_poll_ns(struct kvmppc_vcore *vc)\n" ">> +{\n" ">> + /* 10us base */\n" - ">> + if (vc->halt_poll_ns = 0 && halt_poll_ns_grow)\n" + ">> + if (vc->halt_poll_ns == 0 && halt_poll_ns_grow)\n" ">> + vc->halt_poll_ns = 10000;\n" ">> + else\n" ">> + vc->halt_poll_ns *= halt_poll_ns_grow;\n" @@ -128,7 +128,7 @@ ">> +\n" ">> +static void shrink_halt_poll_ns(struct kvmppc_vcore *vc)\n" ">> +{\n" - ">> + if (halt_poll_ns_shrink = 0)\n" + ">> + if (halt_poll_ns_shrink == 0)\n" ">> + vc->halt_poll_ns = 0;\n" ">> + else\n" ">> + vc->halt_poll_ns /= halt_poll_ns_shrink;\n" @@ -189,7 +189,7 @@ ">> + cur = ktime_get();\n" ">> + } while (ktime_before(cur, stop));\n" "> The generic halt-polling implementation only polls if there are no\n" - "> other threads waiting to run (single_task_running() = 1). Should/Can\n" + "> other threads waiting to run (single_task_running() == 1). Should/Can\n" "> we do the same here?\n" "\n" "Thanks for catching that.\n" @@ -282,4 +282,4 @@ ">> 2.5.5\n" >> -b36ba70b7e49890d779d4d6a6f34b1e17fa1b2f60cd6ecd85ad113cebebaa184 +1e0355e5fef64b6c557b287ae3fbd5638344674b120b831799f76cb88472179b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.