From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbcGUJq0 (ORCPT ); Thu, 21 Jul 2016 05:46:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:22624 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbcGUJqY (ORCPT ); Thu, 21 Jul 2016 05:46:24 -0400 Message-ID: <57909985.9070505@oracle.com> Date: Thu, 21 Jul 2016 17:44:37 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= CC: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, konrad.wilk@oracle.com, jgross@suse.com Subject: Re: [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits() References: <1468575109-12209-1-git-send-email-bob.liu@oracle.com> <1468575109-12209-2-git-send-email-bob.liu@oracle.com> <20160721082913.ahsy5a63ymfoymqv@mac> In-Reply-To: <20160721082913.ahsy5a63ymfoymqv@mac> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/21/2016 04:29 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote: >> blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not >> as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits >> with initial correct values. > > Hm, great, and as usual in Linux there isn't even a comment in the function > that explains what it is supposed to do, or what are the side-effects of > calling blk_mq_update_nr_hw_queues. > >> Signed-off-by: Bob Liu >> >> drivers/block/xen-blkfront.c | 91 ++++++++++++++++++++++++-------------------- >> 1 file changed, 50 insertions(+), 41 deletions(-) >> >> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c >> index 032fc94..10f46a8 100644 >> --- a/drivers/block/xen-blkfront.c >> +++ b/drivers/block/xen-blkfront.c >> @@ -189,6 +189,8 @@ struct blkfront_info >> struct mutex mutex; >> struct xenbus_device *xbdev; >> struct gendisk *gd; >> + u16 sector_size; >> + unsigned int physical_sector_size; >> int vdevice; >> blkif_vdev_t handle; >> enum blkif_state connected; >> @@ -913,9 +915,45 @@ static struct blk_mq_ops blkfront_mq_ops = { >> .map_queue = blk_mq_map_queue, >> }; >> >> +static void blkif_set_queue_limits(struct blkfront_info *info) >> +{ >> + struct request_queue *rq = info->rq; >> + struct gendisk *gd = info->gd; >> + unsigned int segments = info->max_indirect_segments ? : >> + BLKIF_MAX_SEGMENTS_PER_REQUEST; >> + >> + queue_flag_set_unlocked(QUEUE_FLAG_VIRT, rq); >> + >> + if (info->feature_discard) { >> + queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, rq); >> + blk_queue_max_discard_sectors(rq, get_capacity(gd)); >> + rq->limits.discard_granularity = info->discard_granularity; >> + rq->limits.discard_alignment = info->discard_alignment; >> + if (info->feature_secdiscard) >> + queue_flag_set_unlocked(QUEUE_FLAG_SECDISCARD, rq); >> + } > > AFAICT, at the point this function is called (in blkfront_resume), the > value of info->feature_discard is still from the old backend, maybe this > should be called from blkif_recover after blkfront_gather_backend_features? > Thank you for pointing out, will be fixed. -- Regards, -Bob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Liu Subject: Re: [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits() Date: Thu, 21 Jul 2016 17:44:37 +0800 Message-ID: <57909985.9070505@oracle.com> References: <1468575109-12209-1-git-send-email-bob.liu@oracle.com> <1468575109-12209-2-git-send-email-bob.liu@oracle.com> <20160721082913.ahsy5a63ymfoymqv@mac> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQAXj-0003mS-J1 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2016 09:45:23 +0000 In-Reply-To: <20160721082913.ahsy5a63ymfoymqv@mac> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org Ck9uIDA3LzIxLzIwMTYgMDQ6MjkgUE0sIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6Cj4gT24gRnJp LCBKdWwgMTUsIDIwMTYgYXQgMDU6MzE6NDhQTSArMDgwMCwgQm9iIExpdSB3cm90ZToKPj4gYmxr X21xX3VwZGF0ZV9ucl9od19xdWV1ZXMoKSByZXNldCBhbGwgcXVldWUgbGltaXRzIHRvIGRlZmF1 bHQgd2hpY2ggaXQncyBub3QKPj4gYXMgeGVuLWJsa2Zyb250IGV4cGVjdGVkLCBpbnRyb2R1Y2lu ZyBibGtpZl9zZXRfcXVldWVfbGltaXRzKCkgdG8gcmVzZXQgbGltaXRzCj4+IHdpdGggaW5pdGlh bCBjb3JyZWN0IHZhbHVlcy4KPiAKPiBIbSwgZ3JlYXQsIGFuZCBhcyB1c3VhbCBpbiBMaW51eCB0 aGVyZSBpc24ndCBldmVuIGEgY29tbWVudCBpbiB0aGUgZnVuY3Rpb24gCj4gdGhhdCBleHBsYWlu cyB3aGF0IGl0IGlzIHN1cHBvc2VkIHRvIGRvLCBvciB3aGF0IGFyZSB0aGUgc2lkZS1lZmZlY3Rz IG9mIAo+IGNhbGxpbmcgYmxrX21xX3VwZGF0ZV9ucl9od19xdWV1ZXMuCj4gIAo+PiBTaWduZWQt b2ZmLWJ5OiBCb2IgTGl1IDxib2IubGl1QG9yYWNsZS5jb20+Cj4+Cj4+ICBkcml2ZXJzL2Jsb2Nr L3hlbi1ibGtmcm9udC5jIHwgOTEgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCA0MSBkZWxldGlv bnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMgYi9k cml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jCj4+IGluZGV4IDAzMmZjOTQuLjEwZjQ2YTggMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMKPj4gKysrIGIvZHJpdmVy cy9ibG9jay94ZW4tYmxrZnJvbnQuYwo+PiBAQCAtMTg5LDYgKzE4OSw4IEBAIHN0cnVjdCBibGtm cm9udF9pbmZvCj4+ICAJc3RydWN0IG11dGV4IG11dGV4Owo+PiAgCXN0cnVjdCB4ZW5idXNfZGV2 aWNlICp4YmRldjsKPj4gIAlzdHJ1Y3QgZ2VuZGlzayAqZ2Q7Cj4+ICsJdTE2IHNlY3Rvcl9zaXpl Owo+PiArCXVuc2lnbmVkIGludCBwaHlzaWNhbF9zZWN0b3Jfc2l6ZTsKPj4gIAlpbnQgdmRldmlj ZTsKPj4gIAlibGtpZl92ZGV2X3QgaGFuZGxlOwo+PiAgCWVudW0gYmxraWZfc3RhdGUgY29ubmVj dGVkOwo+PiBAQCAtOTEzLDkgKzkxNSw0NSBAQCBzdGF0aWMgc3RydWN0IGJsa19tcV9vcHMgYmxr ZnJvbnRfbXFfb3BzID0gewo+PiAgCS5tYXBfcXVldWUgPSBibGtfbXFfbWFwX3F1ZXVlLAo+PiAg fTsKPj4gIAo+PiArc3RhdGljIHZvaWQgYmxraWZfc2V0X3F1ZXVlX2xpbWl0cyhzdHJ1Y3QgYmxr ZnJvbnRfaW5mbyAqaW5mbykKPj4gK3sKPj4gKwlzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcnEgPSBp bmZvLT5ycTsKPj4gKwlzdHJ1Y3QgZ2VuZGlzayAqZ2QgPSBpbmZvLT5nZDsKPj4gKwl1bnNpZ25l ZCBpbnQgc2VnbWVudHMgPSBpbmZvLT5tYXhfaW5kaXJlY3Rfc2VnbWVudHMgPyA6Cj4+ICsJCQkJ QkxLSUZfTUFYX1NFR01FTlRTX1BFUl9SRVFVRVNUOwo+PiArCj4+ICsJcXVldWVfZmxhZ19zZXRf dW5sb2NrZWQoUVVFVUVfRkxBR19WSVJULCBycSk7Cj4+ICsKPj4gKwlpZiAoaW5mby0+ZmVhdHVy ZV9kaXNjYXJkKSB7Cj4+ICsJCXF1ZXVlX2ZsYWdfc2V0X3VubG9ja2VkKFFVRVVFX0ZMQUdfRElT Q0FSRCwgcnEpOwo+PiArCQlibGtfcXVldWVfbWF4X2Rpc2NhcmRfc2VjdG9ycyhycSwgZ2V0X2Nh cGFjaXR5KGdkKSk7Cj4+ICsJCXJxLT5saW1pdHMuZGlzY2FyZF9ncmFudWxhcml0eSA9IGluZm8t PmRpc2NhcmRfZ3JhbnVsYXJpdHk7Cj4+ICsJCXJxLT5saW1pdHMuZGlzY2FyZF9hbGlnbm1lbnQg PSBpbmZvLT5kaXNjYXJkX2FsaWdubWVudDsKPj4gKwkJaWYgKGluZm8tPmZlYXR1cmVfc2VjZGlz Y2FyZCkKPj4gKwkJCXF1ZXVlX2ZsYWdfc2V0X3VubG9ja2VkKFFVRVVFX0ZMQUdfU0VDRElTQ0FS RCwgcnEpOwo+PiArCX0KPiAKPiBBRkFJQ1QsIGF0IHRoZSBwb2ludCB0aGlzIGZ1bmN0aW9uIGlz IGNhbGxlZCAoaW4gYmxrZnJvbnRfcmVzdW1lKSwgdGhlIAo+IHZhbHVlIG9mIGluZm8tPmZlYXR1 cmVfZGlzY2FyZCBpcyBzdGlsbCBmcm9tIHRoZSBvbGQgYmFja2VuZCwgbWF5YmUgdGhpcyAKPiBz aG91bGQgYmUgY2FsbGVkIGZyb20gYmxraWZfcmVjb3ZlciBhZnRlciBibGtmcm9udF9nYXRoZXJf YmFja2VuZF9mZWF0dXJlcz8KPiAKClRoYW5rIHlvdSBmb3IgcG9pbnRpbmcgb3V0LCB3aWxsIGJl IGZpeGVkLgoKLS0gClJlZ2FyZHMsCi1Cb2IKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz Lnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=