From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 2/7] drm/amdgpu: remove fence_lock
Date: Thu, 21 Jul 2016 18:23:09 +0800 [thread overview]
Message-ID: <5790A28D.40900@amd.com> (raw)
In-Reply-To: <1469095284-2024-2-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
On 2016年07月21日 18:01, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> Was never used as far as I can see.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index d939038..0bc84c3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -775,7 +775,6 @@ struct amdgpu_ring {
> struct amdgpu_fence_driver fence_drv;
> struct amd_gpu_scheduler sched;
>
> - spinlock_t fence_lock;
> struct amdgpu_bo *ring_obj;
> volatile uint32_t *ring;
> unsigned rptr_offs;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> index 3b885e3..f305f63 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> @@ -198,7 +198,6 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
> ring->cond_exe_gpu_addr = adev->wb.gpu_addr + (ring->cond_exe_offs * 4);
> ring->cond_exe_cpu_addr = &adev->wb.wb[ring->cond_exe_offs];
>
> - spin_lock_init(&ring->fence_lock);
> r = amdgpu_fence_driver_start_ring(ring, irq_src, irq_type);
> if (r) {
> dev_err(adev->dev, "failed initializing fences (%d).\n", r);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-07-21 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 10:01 [PATCH 1/7] drm/amdgpu: fix indentation in struct amdgpu_ring Christian König
[not found] ` <1469095284-2024-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-07-21 10:01 ` [PATCH 2/7] drm/amdgpu: remove fence_lock Christian König
[not found] ` <1469095284-2024-2-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-07-21 10:23 ` zhoucm1 [this message]
2016-07-21 10:01 ` [PATCH 3/7] drm/amdgpu: add begin/end_use ring callbacks Christian König
2016-07-21 10:01 ` [PATCH 4/7] drm/amdgpu: use begin/end_use for UVD power/clock gating Christian König
2016-07-21 10:01 ` [PATCH 5/7] drm/amdgpu: use begin/end_use for VCE " Christian König
2016-07-21 10:01 ` [PATCH 6/7] drm/amdgpu: move UVD IB test into common code v2 Christian König
2016-07-21 10:01 ` [PATCH 7/7] drm/amdgpu: add a fence timeout for the IB tests v2 Christian König
[not found] ` <1469095284-2024-7-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-07-21 10:24 ` zhoucm1
2016-07-27 17:57 ` Deucher, Alexander
2016-07-21 10:22 ` [PATCH 1/7] drm/amdgpu: fix indentation in struct amdgpu_ring zhoucm1
2016-07-21 10:24 ` Edward O'Callaghan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5790A28D.40900@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.