From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFAB-0002Xb-Ul for qemu-devel@nongnu.org; Thu, 21 Jul 2016 10:41:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQFA6-0006r0-Ok for qemu-devel@nongnu.org; Thu, 21 Jul 2016 10:41:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFA6-0006qw-IX for qemu-devel@nongnu.org; Thu, 21 Jul 2016 10:41:18 -0400 References: <1469097213-26441-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469097213-26441-2-git-send-email-caoj.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <5790DF0D.60104@redhat.com> Date: Thu, 21 Jul 2016 08:41:17 -0600 MIME-Version: 1.0 In-Reply-To: <1469097213-26441-2-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jr6gHgpUSMLnqFoRabiEk0MBRqNET7A8c" Subject: Re: [Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jr6gHgpUSMLnqFoRabiEk0MBRqNET7A8c From: Eric Blake To: Cao jin , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann Message-ID: <5790DF0D.60104@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect() References: <1469097213-26441-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469097213-26441-2-git-send-email-caoj.fnst@cn.fujitsu.com> In-Reply-To: <1469097213-26441-2-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/21/2016 04:33 AM, Cao jin wrote: > It is never used, and now all connect is nonblocking via > inet_connect_addr(). Maybe the subject line could be: util: Drop unused inet_unblocking_connect() but what you have isn't too bad. >=20 > Cc: Daniel P. Berrange > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > Signed-off-by: Cao jin > --- > include/qemu/sockets.h | 3 --- > util/qemu-sockets.c | 30 ------------------------------ > 2 files changed, 33 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Jr6gHgpUSMLnqFoRabiEk0MBRqNET7A8c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXkN8NAAoJEKeha0olJ0Nq/j4H/RBE1vF9l08u8DrfuWuwHsuI 1gpV4+AJXPNo1q9jv4OyJ+athvL66fAe65Msih/huUKuuy0ZlfZ706Zu34YJyAWq 5KMilYZQsPaSvkzX8MsrHDDL5jchsmi1xSc4+iUXvqYKVQOyerItJXKFTsD7LzXv Wx1SCUONEI0/THn65s2u5L1PwUYopPyaAj0uIfd2oa3llQfLMdFMI5LK0JQId4hH 5su8FRfeNMZVVWBjcrhFGNZD8shrNj33x3z5b9COBbOSrrqkQlQw1hlQM4UVs3Sc blISp/HLUvUtbza95uiI76ds0jvF/fKES3S1wzacTsMZn6bZghLEAI3f7FLeaSI= =1y7C -----END PGP SIGNATURE----- --Jr6gHgpUSMLnqFoRabiEk0MBRqNET7A8c--