From: Ziyuan Xu <xzy.xu@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type
Date: Sat, 23 Jul 2016 11:12:24 +0800 [thread overview]
Message-ID: <5792E098.8040003@rock-chips.com> (raw)
In-Reply-To: <CAPnjgZ0JhAT5SNNt4GN3ZkF9CKZCZKNQ1-OXfggE7Qixw_oGyg@mail.gmail.com>
Hi Simon,
On 2016?07?23? 10:57, Simon Glass wrote:
> Hi,
>
> On 21 July 2016 at 21:21, Simon Glass <sjg@chromium.org> wrote:
>> On 19 July 2016 at 08:21, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>>> From: Xu Ziyuan <xzy.xu@rock-chips.com>
>>>
>>> It's nicer to see this:
>>>
>>> => mmc list
>>> dwmmc at ff0c0000: 0
>>> dwmmc at ff0f0000: 1 (eMMC)
>>>
>>> than this:
>>>
>>> => mmc list
>>> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
>>>
>>> With the latter, it's much clearer which mmc devices are on.
>>>
>>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>>
>>> Serise-changes: 2
>>> - Update commit from Jaehoon
>>>
>>> Signed-off-by: Ziyuan Xu <jk.kernel@gmail.com>
>>> ---
>>>
>>> drivers/mmc/mmc-uclass.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> Thanks for the bug fix.
>>
>> Acked-by: Simon Glass <sjg@chromium.org>
> Please can you send a v2 with the nits fixed?
Fixed, see v3.
>
> - Simon
>
>
>
prev parent reply other threads:[~2016-07-23 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160719142140epcas1p11ff53d15c82f6182d02c2fb5604ed506@epcas1p1.samsung.com>
2016-07-19 14:21 ` [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type Ziyuan Xu
2016-07-21 2:11 ` Jaehoon Chung
2016-07-23 3:11 ` Ziyuan Xu
2016-07-22 3:21 ` Simon Glass
2016-07-23 2:57 ` Simon Glass
2016-07-23 3:12 ` Ziyuan Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5792E098.8040003@rock-chips.com \
--to=xzy.xu@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.