All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ziyuan Xu <xzy.xu@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "rockchip: Move the MMC setup check earlier"
Date: Sat, 23 Jul 2016 11:45:07 +0800	[thread overview]
Message-ID: <5792E843.6000706@rock-chips.com> (raw)
In-Reply-To: <CAPnjgZ0_sdOu3Yggn_vYxN1kHH5cFe5qTs11TcWJt5idkH9pbA@mail.gmail.com>

Hi Simon,

On 2016?07?23? 10:57, Simon Glass wrote:
> On 18 July 2016 at 20:13, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>> Boot Rom wouldn't initialize sdmmc while booting from eMMC. We need to
>> setup sdmmc gpio, otherwise we will hit an error below:
>>
>> =>mmc info
>> blk_get_device: if_type=6, devnum=0: dwmmc at ff0c0000.blk, 6, 0
>> uclass_find_device_by_seq: 0 -1
>> uclass_find_device_by_seq: 0 0
>>     - -1 -1
>>     - -1 0
>>     - found
>> uclass_find_device_by_seq: 0 1
>>     - -1 -1
>>     - -1 0
>>     - not found
>> fdtdec_get_int_array: interrupts
>> get_prop_check_min_len: interrupts
>> Buswidth = 1, clock: 0
>> Buswidth = 1, clock: 400000
>> Sending CMD0
>> dwmci_send_cmd: Timeout on data busy
>> dwmci_send_cmd: Timeout on data busy
>> dwmci_send_cmd: Timeout on data busy
>> dwmci_send_cmd: Timeout on data busy
>>
>> This reverts commit 6efeeea79c880d3dd262e0dca9da2687f0ab68c9.
>>
>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>> ---
>>
>>   arch/arm/mach-rockchip/rk3288-board-spl.c | 28 ++++++++++++++--------------
>>   1 file changed, 14 insertions(+), 14 deletions(-)
> Acked-by: Simon Glass <sjg@chromium.org>
> Tested on firefly-rk3288:
> Tested-by: Simon Glass <sjg@chromium.org>
>
> I think this is safe to apply now that we have reduced SPL size.
Did you mean that commit 
97feca3325bb2065a7ef7d30e1f308b74f1fb33c(rockchip: Use of-platdata for 
firefly-rk3288)?
If you recommend that use of-platfdata instead of of-libfd, I will 
revise it on evb-rk32288 & fennect-rk3288 board.

>
> - Simon
>
>
>

  reply	other threads:[~2016-07-23  3:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19  2:13 [U-Boot] [PATCH] Revert "rockchip: Move the MMC setup check earlier" Ziyuan Xu
2016-07-23  2:57 ` Simon Glass
2016-07-23  3:45   ` Ziyuan Xu [this message]
2016-07-25  2:07     ` Simon Glass
2016-07-25  2:20       ` Ziyuan Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5792E843.6000706@rock-chips.com \
    --to=xzy.xu@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.