From: Guenter Roeck <linux@roeck-us.net>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Chris Zankel <chris@zankel.net>,
"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
LKML <linux-kernel@vger.kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH -next] xtensa: Fix build error due to missing include file
Date: Sat, 23 Jul 2016 23:00:12 -0700 [thread overview]
Message-ID: <5794596C.6040809@roeck-us.net> (raw)
In-Reply-To: <CAMo8BfK_iOCpByVPdOSceSktVEcL+35=dkwiB7j5oLFuYZPb0w@mail.gmail.com>
On 07/23/2016 05:45 PM, Max Filippov wrote:
> On Sun, Jul 24, 2016 at 3:24 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>> Commit 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate
>> with default match table") dropped various include files from
>> arch/xtensa/kernel/setup.c. This results in the following build error.
>>
>> arch/xtensa/kernel/setup.c: In function ‘xtensa_dt_io_area’:
>> arch/xtensa/kernel/setup.c:213:2: error:
>> implicit declaration of function ‘of_read_ulong’
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
>> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
>> Cc: Rob Herring <robh@kernel.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I would suggest to merge this patch into the commit causing the problem
>> if possible.
>>
>> arch/xtensa/kernel/setup.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Acked-by: Max Filippov <jcmvbkbc@gmail.com>
>
Heads up: xtensa images build after this patch, but the image that
previously failed to build (generic_kc705_defconfig) doesn't boot,
at least not with qemu. I don't know if this is caused by 69d99e6c0d621f
or by some other patch.
Guenter
next prev parent reply other threads:[~2016-07-24 6:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 0:24 [PATCH -next] xtensa: Fix build error due to missing include file Guenter Roeck
2016-07-24 0:45 ` Max Filippov
2016-07-24 6:00 ` Guenter Roeck [this message]
2016-07-24 14:20 ` Max Filippov
2016-07-24 15:18 ` Rob Herring
2016-07-24 16:27 ` Guenter Roeck
2016-07-25 8:07 ` Max Filippov
2016-07-25 13:22 ` Rob Herring
2016-07-25 20:02 ` Max Filippov
2016-07-25 20:51 ` Guenter Roeck
2016-07-25 22:24 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5794596C.6040809@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=robh@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.