From: Guenter Roeck <linux@roeck-us.net>
To: Jonathan Cameron <jic23@kernel.org>, Jean Delvare <jdelvare@suse.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Punit Agrawal <punit.agrawal@arm.com>,
linux-pm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API
Date: Sun, 24 Jul 2016 19:55:24 -0700 [thread overview]
Message-ID: <57957F9C.8060100@roeck-us.net> (raw)
In-Reply-To: <15243498-d127-0c1a-ea3f-dfa28f5bf2ee@kernel.org>
On 07/24/2016 12:08 PM, Jonathan Cameron wrote:
> On 17/07/16 06:30, Guenter Roeck wrote:
>> Up to now, each hwmon driver has to implement its own sysfs attributes.
>> This requires a lot of template code, and distracts from the driver's core
>> function to read and write chip registers.
>>
>> To be able to reduce driver complexity, move sensor attribute handling
>> and thermal zone registration into hwmon core. By using the new API,
>> driver code and data size is typically reduced by 20-70%, depending
>> on driver complexity and the number of sysfs attributes supported.
>>
>> With this patch, the new API only supports thermal sensors. Support for
>> other sensor types will be added with subsequent patches.
>>
> Looks good to me which is pretty unusual for a V2 of anything ;)
>
Thanks ... unfortunately, it wasn't perfect, so I'll have to send another version.
The thermal code needs to be surrounded with "#if IS_REACHABLE(CONFIG_THERMAL)
&& defined(CONFIG_THERMAL_OF)".
Guenter
next prev parent reply other threads:[~2016-07-25 2:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 5:30 [PATCH v2 0/9] hwmon: New hwmon registration API Guenter Roeck
2016-07-17 5:30 ` Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 1/9] hwmon: (core) Order include files alphabetically Guenter Roeck
2016-07-17 5:30 ` Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 2/9] hwmon: (core) New hwmon registration API Guenter Roeck
2016-07-20 7:18 ` [lkp] " Fengguang Wu
2016-07-20 7:18 ` Fengguang Wu
2016-07-24 19:08 ` Jonathan Cameron
2016-07-25 2:55 ` Guenter Roeck [this message]
2016-07-17 5:30 ` [PATCH v2 3/9] hwmon: (core) Add voltage attribute support to new API Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 4/9] hwmon: (core) Add current " Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 5/9] hwmon: (core) Add power " Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 6/9] hwmon: (core) Add energy and humidity " Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 7/9] hwmon: (core) Add fan " Guenter Roeck
2016-07-17 5:30 ` Guenter Roeck
2016-07-17 5:30 ` [PATCH v2 8/9] hwmon: (core) Document new kernel API Guenter Roeck
2016-07-17 5:30 ` Guenter Roeck
2016-07-24 19:18 ` Jonathan Cameron
2016-07-17 5:30 ` [PATCH v2 9/9] hwmon: (core) Add basic pwm attribute support to new API Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57957F9C.8060100@roeck-us.net \
--to=linux@roeck-us.net \
--cc=edubezval@gmail.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.