Re: net/pcap: set rte_errno on TX error

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 7/25/2016 2:10 PM, Zoltan Kiss wrote:
> This returns the error code provided by pcap_sendpacket()

Although this is good idea, this adds undocumented side effect to
rte_eth_tx_burst().

I am not able to find any information in rte_eth_tx_burst() that it can
alter rte_errno.

Since rte_errno is shared resource, it shouldn't be updated without
documented.

> 
> Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu>
> 
> diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
> index 7e213eb..0899bac 100644
> --- a/drivers/net/pcap/rte_eth_pcap.c
> +++ b/drivers/net/pcap/rte_eth_pcap.c
> @@ -41,6 +41,7 @@
>  #include <rte_cycles.h>
>  #include <rte_kvargs.h>
>  #include <rte_dev.h>
> +#include <rte_errno.h>
>  
>  #include <net/if.h>
>  
> @@ -360,8 +361,10 @@ eth_pcap_tx(void *queue,
>  			}
>  		}
>  
> -		if (unlikely(ret != 0))
> +		if (unlikely(ret != 0)) {
> +			rte_errno = ret;
>  			break;
> +		}
>  		num_tx++;
>  		tx_bytes += mbuf->pkt_len;
>  		rte_pktmbuf_free(mbuf);
>