From: Richard Weinberger <richard@nod.at>
To: Greg KH <greg@kroah.com>
Cc: Rajeev Kumar <rajeev_kumar@mentor.com>,
dwmw2@infradead.org, computersforpeace@gmail.com,
dedekind1@gmail.com, linux-mtd@lists.infradead.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] MTD: UBI: speed up init by moving status messages to debugfs
Date: Mon, 25 Jul 2016 22:39:10 +0200 [thread overview]
Message-ID: <579678EE.4010408@nod.at> (raw)
In-Reply-To: <20160725164708.GB7540@kroah.com>
Am 25.07.2016 um 18:47 schrieb Greg KH:
> On Mon, Jul 25, 2016 at 01:32:30PM +0200, Richard Weinberger wrote:
>> These days I'd not print all of them. But we do already and I know
>> setups which parse dmesg and grep for some of these values.
>
> That's horrid and should not be tolerated, please never grep the kernel
> log for anything.
>
>> Either to see whether attach worked or just to gather debug infos for
>> QA.
>> I don't want to risk breaking existing stuff.
>
> We do not claim that kernel log messages are an "ABI" that can not be
> changed or broken at all.
I know, but today I'm less sadistic than usual and allow users to keep their
stuff.
Rajeev's issue is not related to UBI and can be solved in a generic and sane
way using loglevels. So there is no need to change the existing logging.
Thanks,
//richard
prev parent reply other threads:[~2016-07-25 20:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 9:46 [PATCH 1/2] MTD: UBI: speed up init by moving status messages to debugfs Rajeev Kumar
2016-07-25 9:46 ` [PATCH 2/2] ubi: attach: do not return -EINVAL if the mtd->numeraseregions is 1 Rajeev Kumar
2016-07-25 10:31 ` Richard Weinberger
2016-07-25 11:16 ` Rajeev Kumar
2016-07-25 11:20 ` Richard Weinberger
2016-07-29 18:24 ` Brian Norris
2016-08-04 6:30 ` Artem Bityutskiy
2016-09-23 11:20 ` Chugh, Sanjeev
2016-09-23 11:37 ` Chugh, Sanjeev
2016-10-26 12:26 ` Chugh, Sanjeev
2016-07-25 10:31 ` [PATCH 1/2] MTD: UBI: speed up init by moving status messages to debugfs Richard Weinberger
2016-07-25 11:23 ` Rajeev Kumar
2016-07-25 11:32 ` Richard Weinberger
2016-07-25 16:47 ` Greg KH
2016-07-25 20:39 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579678EE.4010408@nod.at \
--to=richard@nod.at \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=linux-mtd@lists.infradead.org \
--cc=rajeev_kumar@mentor.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.