From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1bRr62-0002fa-CU
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 21:23:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1bRr60-0001la-R9
	for qemu-devel@nongnu.org; Mon, 25 Jul 2016 21:23:45 -0400
Message-ID: <5796BCB1.7080504@cn.fujitsu.com>
Date: Tue, 26 Jul 2016 09:28:17 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com>
	<1469182567-3114-3-git-send-email-wangww.fnst@cn.fujitsu.com>
	<26e14cef-52af-14b2-fa0f-802d568ae638@redhat.com>
In-Reply-To: <26e14cef-52af-14b2-fa0f-802d568ae638@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v22 02/10] Backup: clear all bitmap when
 doing block checkpoint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, Wang WeiWei <wangww.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, qemu block <qemu-block@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David
	Alan Gilbert" <dgilbert@redhat.com>, Dong Eddie <eddie.dong@intel.com>, Jiang Yunhong <yunhong.jiang@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Gonglei <arei.gonglei@huawei.com>, Wen Congyang <wency@cn.fujitsu.com>

On 07/26/2016 05:18 AM, Max Reitz wrote:
> On 22.07.2016 12:15, Wang WeiWei wrote:
>> From: Wen Congyang <wency@cn.fujitsu.com>
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com>
>> ---
>>   block/backup.c               | 18 ++++++++++++++++++
>>   include/block/block_backup.h |  3 +++
>>   2 files changed, 21 insertions(+)
>>   create mode 100644 include/block/block_backup.h
>
> [...]
>
>> diff --git a/include/block/block_backup.h b/include/block/block_backup.h
>> new file mode 100644
>> index 0000000..3753bcb
>> --- /dev/null
>> +++ b/include/block/block_backup.h
>> @@ -0,0 +1,3 @@
>> +#include "block/block_int.h"
>> +
>> +void backup_do_checkpoint(BlockJob *job, Error **errp);
>
> Include guards and copyright notice missing. I don't mind the missing
> copyright notice because it will default to GPL anyway. Also, I

I think i can copy the Copyright from backup.c and update it

> personally don't really mind the missing include guards, but I thought

Btw i'll add #ifndef...#define...#endif in next version

> I'd say something anyway.

warm welcome

>
> Max
>