From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bRwh0-0000Ye-4s
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 03:22:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bRwgw-0001NU-Qa
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 03:22:17 -0400
Received: from [59.151.112.132] (port=9820 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1bRwgw-0001MH-E8
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 03:22:14 -0400
References: <1467733400-17206-1-git-send-email-mst@redhat.com>
	<20160705184740-mutt-send-email-mst@redhat.com>
	<20160726050159.GA27202@grmbl.mre>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <57971160.5090509@cn.fujitsu.com>
Date: Tue, 26 Jul 2016 15:29:36 +0800
MIME-Version: 1.0
In-Reply-To: <20160726050159.GA27202@grmbl.mre>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary
 internal msi state flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>



On 07/26/2016 01:01 PM, Amit Shah wrote:
> On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote:
>> From: Cao jin <caoj.fnst@cn.fujitsu.com>
>>
>> internal flag msi_in_use in unnecessary, msi_uninit() could be called
>> directly, and msi_enabled() is enough to check device msi state.
>>
>> cc: Markus Armbruster <armbru@redhat.com>
>> cc: Marcel Apfelbaum <marcel@redhat.com>
>> cc: Paolo Bonzini <pbonzini@redhat.com>
>> cc: Michael S. Tsirkin <mst@redhat.com>
>>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> [...]
>
>>   static void mptsas_reset(DeviceState *dev)
>> @@ -1375,7 +1370,6 @@ static const VMStateDescription vmstate_mptsas = {
>>       .post_load = mptsas_post_load,
>>       .fields      = (VMStateField[]) {
>>           VMSTATE_PCI_DEVICE(dev, MPTSASState),
>> -        VMSTATE_BOOL(msi_in_use, MPTSASState),
>
> This removes vmstate -- please use 'unused' instead of removing this
> value.
>
> Flagged by the static checker.
>
>

Hi Amit

I will take care of this.
BTW, did't see it in coverity scan outstanding defects, Do I missed or 
it is checked by other static check tools?
-- 
Yours Sincerely,

Cao jin