From: Mariano Lopez <mariano.lopez@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] oeqa/utils/commands.py: Add oeqa_copy function
Date: Tue, 26 Jul 2016 12:34:47 -0500 [thread overview]
Message-ID: <57979F37.5090304@linux.intel.com> (raw)
In-Reply-To: <CAJTo0LZ_xcHiNGjWs7bJ7G9Tm6Zn5PDyPK5ppXHCdC7fekSk0g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On 07/26/2016 11:13 AM, Burton, Ross wrote:
>
> On 26 July 2016 at 08:39, <mariano.lopez@linux.intel.com
> <mailto:mariano.lopez@linux.intel.com>> wrote:
>
> +def oeqa_copy(src, dst):
> + """
> + Copy files and symlinks trying to preserve metadata.
> + """
> +
> + shutil.copy2(src, dst, follow_symlinks=False)
>
>
> Why not just use shutil directly instead of having a wrapper function?
shutil.copytree didn't play nice with the symlinks, this is why I added
this function, nevertheless, I like Joshua's approach of use
oe.path.copytree(), so this function won't be needed.
>
> Ross
Mariano
[-- Attachment #2: Type: text/html, Size: 2002 bytes --]
next prev parent reply other threads:[~2016-07-26 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 7:39 [PATCH 0/3] Allows to copy symlinks to DUTs with testimage mariano.lopez
2016-07-26 7:39 ` [PATCH 1/3] oeqa/utils/commands.py: Add oeqa_copy function mariano.lopez
2016-07-26 16:13 ` Burton, Ross
2016-07-26 17:34 ` Mariano Lopez [this message]
2016-07-26 7:39 ` [PATCH 2/3] oeqa/oetest.py: Allow to export packages using symlinks mariano.lopez
2016-07-26 7:39 ` [PATCH 3/3] oeqa/utils/sshcontrol.py: Allows to copy symlinks to target mariano.lopez
2016-07-26 16:27 ` [PATCH 0/3] Allows to copy symlinks to DUTs with testimage Joshua G Lock
2016-07-26 17:35 ` Mariano Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57979F37.5090304@linux.intel.com \
--to=mariano.lopez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.