All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCHv2] builddeb: fix file permissions before packaging
Date: Tue, 26 Jul 2016 22:27:19 +0200	[thread overview]
Message-ID: <5797C7A7.90907@suse.com> (raw)
In-Reply-To: <1469191612-21934-1-git-send-email-henning.schild@siemens.com>

Dne 22.7.2016 v 14:46 Henning Schild napsal(a):
> Builddep is not very explicit about file permissions. Actually the file
> permissions in the package are largely influenced by the umask of the
> user cloning the git and building the package. If that umask does not
> set go+r the resulting linux-headers package will prevent non-root users
> from building out-of-tree modules. And that is probably just one
> unexpected effect.
> Being a packaging/install tool builddep should make sure the file
> permissions are set correctly and not just derived from a value that is
> never checked.
> 
> This patch sets ugo read permissions for all packaged files and derives
> the executable bit for directories and executables from the file-owner.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  scripts/package/builddeb | 2 ++
>  1 file changed, 2 insertions(+)

Applied to kbuild.git#misc, thanks.

Michal


  reply	other threads:[~2016-07-26 20:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 14:50 [PATCH] builddeb: fix file permissions before packaging Henning Schild
2016-07-07 14:56 ` Henning Schild
2016-07-07 14:56   ` Henning Schild
2016-07-22 12:15 ` Michal Marek
2016-07-22 12:46   ` [PATCHv2] " Henning Schild
2016-07-26 20:27     ` Michal Marek [this message]
2016-07-22 12:48   ` [PATCH] " Henning Schild
2016-07-22 12:48     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5797C7A7.90907@suse.com \
    --to=mmarek@suse.com \
    --cc=henning.schild@siemens.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.