From: Arun Siluvery <arun.siluvery@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 03/11] drm/i915/tdr: Update reset_in_progress to account for engine reset
Date: Wed, 27 Jul 2016 12:52:09 +0100 [thread overview]
Message-ID: <5798A069.3060903@linux.intel.com> (raw)
In-Reply-To: <20160727114128.GG20724@nuc-i3427.alporthouse.com>
On 27/07/2016 12:41, Chris Wilson wrote:
> On Wed, Jul 27, 2016 at 12:16:04PM +0100, Arun Siluvery wrote:
>> On 26/07/2016 22:52, Chris Wilson wrote:
>>> A totally unexplained change. If it is because you think to want to break
>>> waiters on struct_mutex, try again.
>> So you don't want error->flags to include engine reset bits?
>> ok, it should be possible to use engine_mask itself.
>>
>> Next patch separates engine reset and full gpu reset in separate
>> functions, for branching purposes i915_full_gpu_reset_in_progress()
>> is added, is this ok or directly use test_bit() ?
>
> The bit serves 2 functions: serialise error handling, and waking up
> waiters on the struct_mutex. That second function is exposed through the
> i915_reset_in_progress(), which is being altered here without explaining
> how the changed semantics impacts the current users or why it is
> necessary. imo we can do engine resets without struct_mutex.
Yes, as you suggested I am not taking struct_mutex now but adding engine
reset bits to error->flags was breaking the waiters. I will try to use
engine_mask itself and keep error->flags unchanged.
regards
Arun
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-27 11:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 16:40 [PATCH 00/11] Execlist based Engine reset patches Arun Siluvery
2016-07-26 16:40 ` [PATCH 01/11] drm/i915: Update i915.reset to handle engine resets Arun Siluvery
2016-07-26 16:40 ` [PATCH 02/11] drm/i915: Separate out reset flags from the reset counter Arun Siluvery
2016-07-26 16:40 ` [PATCH 03/11] drm/i915/tdr: Update reset_in_progress to account for engine reset Arun Siluvery
2016-07-26 21:52 ` Chris Wilson
2016-07-27 11:16 ` Arun Siluvery
2016-07-27 11:41 ` Chris Wilson
2016-07-27 11:52 ` Arun Siluvery [this message]
2016-07-26 16:40 ` [PATCH 04/11] drm/i915/tdr: Modify error handler for per engine hang recovery Arun Siluvery
2016-07-26 16:40 ` [PATCH 05/11] drm/i915/tdr: Identify hung request and drop it Arun Siluvery
2016-07-26 21:37 ` Chris Wilson
2016-07-27 11:54 ` Arun Siluvery
2016-07-27 12:27 ` Chris Wilson
2016-07-27 21:35 ` Resubmitting requests following the hang Chris Wilson
2016-07-27 21:35 ` [PATCH 1/3] drm/i915: Record the position of the start of the request Chris Wilson
2016-07-27 21:35 ` [PATCH 2/3] lrc Chris Wilson
2016-07-27 21:36 ` [PATCH 3/3] reset-request-recovery Chris Wilson
2016-07-26 16:40 ` [PATCH 06/11] drm/i915/tdr: Restart submission after engine reset Arun Siluvery
2016-07-26 21:32 ` Chris Wilson
2016-07-26 16:40 ` [PATCH 07/11] drm/i915/tdr: Add support for per engine reset recovery Arun Siluvery
2016-07-26 21:51 ` Chris Wilson
2016-07-27 11:49 ` Arun Siluvery
2016-07-26 16:40 ` [PATCH 08/11] drm/i915: Skip reset request if there is one already Arun Siluvery
2016-07-26 16:40 ` [PATCH 09/11] drm/i915/tdr: Add engine reset count to error state Arun Siluvery
2016-07-26 16:40 ` [PATCH 10/11] drm/i915/tdr: Export reset count info to debugfs Arun Siluvery
2016-07-26 16:40 ` [PATCH 11/11] drm/i915/tdr: Enable Engine reset and recovery support Arun Siluvery
2016-07-26 17:11 ` ✗ Ro.CI.BAT: failure for Execlist based Engine reset patches Patchwork
2016-07-28 5:40 ` ✗ Ro.CI.BAT: failure for Execlist based Engine reset patches (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5798A069.3060903@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.