From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSQnC-00008i-Kb for qemu-devel@nongnu.org; Wed, 27 Jul 2016 11:30:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSQn7-00042w-3Q for qemu-devel@nongnu.org; Wed, 27 Jul 2016 11:30:40 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37370 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSQn6-00042c-M2 for qemu-devel@nongnu.org; Wed, 27 Jul 2016 11:30:36 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6RFScO9083195 for ; Wed, 27 Jul 2016 11:30:36 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 24edmaa22q-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 27 Jul 2016 11:30:36 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Jul 2016 16:30:34 +0100 References: <1469633297-22808-1-git-send-email-pasic@linux.vnet.ibm.com> From: Halil Pasic Date: Wed, 27 Jul 2016 17:29:20 +0200 MIME-Version: 1.0 In-Reply-To: <1469633297-22808-1-git-send-email-pasic@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: <5798D350.8050802@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/1] block: improve error handling in raw_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , Cornelia Huck , qemu-devel@nongnu.org, Max Reitz On 07/27/2016 05:28 PM, Halil Pasic wrote: > Make raw_open for POSIX more consistent in handling errors by setting > the error object also when qemu_open fails. The error object was set > generally set in case of errors, but I guess this case was overlooked. > Do the same for win32. > > Signed-off-by: Halil Pasic > Reviewed-by: Sascha Silbe > Tested-by: Marc Hartmayer (POSIX only) > > --- > > Stumbled upon this (POSIX) while testing VMs with too many SCSI disks in > respect to my nofile limit. When open hits the nofile limit while trying > to hotplug yet another SCSI disk via libvirt we end up with no adequate > error message (one stating too many files). Sadly this patch in not > sufficient to fix this problem because drive_new (/qemu/blockdev.c) > handles errors using error_report_err which is documented as not to be > used in QMP context. Do not have a patch for that, because I'm unsure > whats the best way to deal with it. My guess right now is to make sure > we propagate errors at least until reaching code which is called only > QMP in context and handle communicating the error to the requester of > the operation there. Any suggestions or ideas? > > The win32 part was not tested, and the sole reason I touched it is > to not introduce unnecessary divergence. > > v2 -> v3: > * first save errno then error_setg_errno > v1 -> v2: > * fixed win32 by the correct error_setg_* > * use the original errno consequently > --- > block/raw-posix.c | 1 + > block/raw-win32.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index 6ed7547..51e4ddb 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -436,6 +436,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, > fd = qemu_open(filename, s->open_flags, 0644); > if (fd < 0) { > ret = -errno; > + error_setg_errno(errp, errno, "Could not open file"); > if (ret == -EROFS) { > ret = -EACCES; > } > diff --git a/block/raw-win32.c b/block/raw-win32.c > index 56f45fe..185dd9b 100644 > --- a/block/raw-win32.c > +++ b/block/raw-win32.c > @@ -338,6 +338,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags, > if (s->hfile == INVALID_HANDLE_VALUE) { > int err = GetLastError(); > > + error_setg_win32(errp, err, "Could not open file"); > if (err == ERROR_ACCESS_DENIED) { > ret = -EACCES; > } else { > Sorry its v3.