From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSa3v-0004MN-Cs for qemu-devel@nongnu.org; Wed, 27 Jul 2016 21:24:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSa3r-0008Vj-6l for qemu-devel@nongnu.org; Wed, 27 Jul 2016 21:24:34 -0400 Received: from [59.151.112.132] (port=21410 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSa3q-0008RR-FP for qemu-devel@nongnu.org; Wed, 27 Jul 2016 21:24:31 -0400 References: <1469451771-1173-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469451771-1173-3-git-send-email-caoj.fnst@cn.fujitsu.com> <20160727113625.GI29546@redhat.com> From: Cao jin Message-ID: <5799607D.4030208@cn.fujitsu.com> Date: Thu, 28 Jul 2016 09:31:41 +0800 MIME-Version: 1.0 In-Reply-To: <20160727113625.GI29546@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Eric Blake On 07/27/2016 07:36 PM, Daniel P. Berrange wrote: > On Mon, Jul 25, 2016 at 09:02:51PM +0800, Cao jin wrote: >> Since commit e65c67e4, inet_listen() is not used anymore, and all >> inet listen operation goes through QIOChannel. >> >> Cc: Daniel P. Berrange >> Cc: Gerd Hoffmann >> Cc: Paolo Bonzini >> Cc: Eric Blake >> >> Signed-off-by: Cao jin >> --- >> include/qemu/sockets.h | 2 -- >> util/qemu-sockets.c | 28 ---------------------------- >> 2 files changed, 30 deletions(-) > > Reviewed-by: Daniel P. Berrange > >> diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h >> index 28a28c0..9eb2470 100644 >> --- a/include/qemu/sockets.h >> +++ b/include/qemu/sockets.h >> @@ -33,8 +33,6 @@ int socket_set_fast_reuse(int fd); >> typedef void NonBlockingConnectHandler(int fd, Error *err, void *opaque); > > There's still scope for a 3rd patch to remove this NonBlockingConnectHandler > typedef, since nothing uses it anymore. > Definitely, I am working on the patch that remove the whole obsolete non-blocking connecting mechanism. > > Regards, > Daniel > -- Yours Sincerely, Cao jin