From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSbEF-0002Ot-Bl for qemu-devel@nongnu.org; Wed, 27 Jul 2016 22:39:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSbED-0007yD-DT for qemu-devel@nongnu.org; Wed, 27 Jul 2016 22:39:18 -0400 References: <1469129688-22848-1-git-send-email-eblake@redhat.com> <1469129688-22848-5-git-send-email-eblake@redhat.com> <20160727072543.GF23258@ad.usersys.redhat.com> From: Eric Blake Message-ID: <5799704D.9060408@redhat.com> Date: Wed, 27 Jul 2016 20:39:09 -0600 MIME-Version: 1.0 In-Reply-To: <20160727072543.GF23258@ad.usersys.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M2IhKqljriX1cvgLvSAMq07oOudc0dvC0" Subject: Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, pl@kamp.de, pbonzini@redhat.com, Stefan Hajnoczi , Kevin Wolf , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M2IhKqljriX1cvgLvSAMq07oOudc0dvC0 From: Eric Blake To: Fam Zheng Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, pl@kamp.de, pbonzini@redhat.com, Stefan Hajnoczi , Kevin Wolf , Max Reitz Message-ID: <5799704D.9060408@redhat.com> Subject: Re: [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard References: <1469129688-22848-1-git-send-email-eblake@redhat.com> <1469129688-22848-5-git-send-email-eblake@redhat.com> <20160727072543.GF23258@ad.usersys.redhat.com> In-Reply-To: <20160727072543.GF23258@ad.usersys.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/27/2016 01:25 AM, Fam Zheng wrote: > On Thu, 07/21 13:34, Eric Blake wrote: >> + max_write_zeroes =3D max_write_zeroes / alignment * alignment; >=20 > Not using QEMU_ALIGN_DOWN despite patch 3? Looks like I missed that on the rebase. Can fix if there is a reason for a respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M2IhKqljriX1cvgLvSAMq07oOudc0dvC0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXmXBNAAoJEKeha0olJ0NqPUQH/A8yuj+QjnkorbCb3SBDbqVV 70q87w9yo+waZlf59vipSXsue2YSjDHrtQ8jVWZjkzX+zzdD79SXpL+M+pBQCbDx wEDNTgiyFrKFiCWPjaXhj67YYCzPUD+KcHLQITSpByS4hPlMAOg3p2JTD+TwGclw N0zkZbGN5dAQSN7dWnczTaM8JefYRT6gtIGqjnGP23vobttBtON4synuk1Y2gq7j AYlXFreML66kTTWcoUHBqQFw84jyOLnzZWqH7/HZwWOV0Q8Rts+Py55hGok7B9yD tBXs3WilFYkyOMVTbWJMeYeeR34dscrx+sx+Hc9jZd0VYZyBNJS2ZuXS90GChME= =Ctan -----END PGP SIGNATURE----- --M2IhKqljriX1cvgLvSAMq07oOudc0dvC0--