From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSbbb-0003gE-0f for qemu-devel@nongnu.org; Wed, 27 Jul 2016 23:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSbbW-00063Y-Qa for qemu-devel@nongnu.org; Wed, 27 Jul 2016 23:03:25 -0400 References: <1469633448-10692-1-git-send-email-brogers@suse.com> From: Cao jin Message-ID: <579977B8.4090600@cn.fujitsu.com> Date: Thu, 28 Jul 2016 11:10:48 +0800 MIME-Version: 1.0 In-Reply-To: <1469633448-10692-1-git-send-email-brogers@suse.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, anthony.perard@citrix.com hello bruce, AFAIK, the message in error object will be printed to stderr or current monitor according whether we have a monitor. I just checked XEN_PT_LOG, message is only printed to stderr. If Xen pt device can be hotplugged via monitor command device_add, I guess using error object is right. Yours Sincerely, Cao jin On 07/27/2016 11:30 PM, Bruce Rogers wrote: > Commit 5a11d0f7 mistakenly converted a log message into an error > condition when no pin interrupt is found for the pci device being > passed through. Revert that part of the commit. > > Signed-off-by: Bruce Rogers > --- > hw/xen/xen_pt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index f593b04..b6d71bb 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -842,7 +842,7 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > goto err_out; > } > if (!scratch) { > - error_setg(errp, "no pin interrupt"); > + XEN_PT_LOG(d, "no pin interrupt\n"); > goto out; > } > >