Re: [Qemu-devel] [PATCH 2/3] util: fix some coding style issue

[Cao jin <caoj.fnst@cn.fujitsu.com>]

On 07/28/2016 04:08 PM, Daniel P. Berrange wrote:
> On Thu, Jul 28, 2016 at 03:39:30PM +0800, Cao jin wrote:
>> Fix some coding style issues found in removing NonBlockingConnectHandler.
>>
>> Cc: Daniel P. Berrange <berrange@redhat.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>> ---
>>   util/qemu-sockets.c | 16 +++++++++++-----
>>   1 file changed, 11 insertions(+), 5 deletions(-)
>
> Reviwed-by: Daniel P. Berrange <berrange@redhat.com>
>
>
>> @@ -443,12 +443,16 @@ static int inet_dgram_saddr(InetSocketAddress *sraddr,
>>       return sock;
>>
>>   err:
>> -    if (-1 != sock)
>> +    if (-1 != sock) {
>
> I'd probably fix the yoda-conditional here too. ie sock != -1 instead.
>
Just find this file mixes yoda-condition and non-yoda-condition.
ok, I can do it, v2 on the way.

-- 
Yours Sincerely,

Cao jin