Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t

[David Vrabel <david.vrabel@citrix.com>]

On 28/07/16 17:24, Vitaly Kuznetsov wrote:
> We pass xen_vcpu_id mapping information to hypercalls which require
> uint32_t type so it would be cleaner to have it as uint32_t. The
> initializer to -1 can be dropped as we always do the mapping before using
> it and we never check the 'not set' value anyway.
[...]
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -9,7 +9,7 @@
>  
>  DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>  
> -DECLARE_PER_CPU(int, xen_vcpu_id);
> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
>  static inline int xen_vcpu_nr(int cpu)

Should the return type of this change to uint32_t as well?

>  {
>  	return per_cpu(xen_vcpu_id, cpu);
> 

David