Build errors in v3.2-stable-queue

Build errors in v3.2-stable-queue

[Guenter Roeck]

alpha:defconfig:

arch/alpha/kernel/io.c:620:15: error: redefinition of ‘ioport_map’
  void __iomem *ioport_map(unsigned long port, unsigned int size)
                ^
In file included from arch/alpha/kernel/io.c:9:0:
/opt/buildbot/slave/qemu-3.2/build/arch/alpha/include/asm/io.h:277:29: note: previous definition of ‘ioport_map’ was here

arch/alpha/kernel/io.c:625:6: error: redefinition of ‘ioport_unmap’

mips:malta_defconfig:

   CC      arch/mips/kernel/asm-offsets.s
In file included from include/linux/mm.h:43:0,
                  from arch/mips/kernel/asm-offsets.c:14:
/opt/buildbot/slave/qemu-3.2/build/arch/mips/include/asm/pgtable.h: In function 'set_pte':
/opt/buildbot/slave/qemu-3.2/build/arch/mips/include/asm/pgtable.h:193:12: error: expected ':' or ')' before 'MIPS_ISA_ARCH_LEVEL'
/opt/buildbot/slave/qemu-3.2/build/./Kbuild:81: recipe for target 'arch/mips/kernel/asm-offsets.s' failed
make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1

Guenter

Re: Build errors in v3.2-stable-queue

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

On Thu, 2016-07-28 at 20:58 -0700, Guenter Roeck wrote:
> alpha:defconfig:
> 
> arch/alpha/kernel/io.c:620:15: error: redefinition of ‘ioport_map’
>   void __iomem *ioport_map(unsigned long port, unsigned int size)
>                 ^
> In file included from arch/alpha/kernel/io.c:9:0:
> /opt/buildbot/slave/qemu-3.2/build/arch/alpha/include/asm/io.h:277:29: note: previous definition of ‘ioport_map’ was here
> 
> arch/alpha/kernel/io.c:625:6: error: redefinition of ‘ioport_unmap’

This is due to a compiler change, not a code change.  It seems to still
be broken upstream, as well.

> mips:malta_defconfig:
> 
>    CC      arch/mips/kernel/asm-offsets.s
> In file included from include/linux/mm.h:43:0,
>                   from arch/mips/kernel/asm-offsets.c:14:
> /opt/buildbot/slave/qemu-3.2/build/arch/mips/include/asm/pgtable.h: In function 'set_pte':
> /opt/buildbot/slave/qemu-3.2/build/arch/mips/include/asm/pgtable.h:193:12: error: expected ':' or ')' before 'MIPS_ISA_ARCH_LEVEL'
> /opt/buildbot/slave/qemu-3.2/build/./Kbuild:81: recipe for target 'arch/mips/kernel/asm-offsets.s' failed
> make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1

OK, I see how to fix that.

Ben.

-- 

Ben Hutchings
Experience is directly proportional to the value of equipment
destroyed.
                                                         - Carolyn
Scheppner

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Build errors in v3.2-stable-queue

[Guenter Roeck]

On 07/30/2016 12:18 PM, Ben Hutchings wrote:
> On Thu, 2016-07-28 at 20:58 -0700, Guenter Roeck wrote:
>> alpha:defconfig:
>>
>> arch/alpha/kernel/io.c:620:15: error: redefinition of ‘ioport_map’
>>    void __iomem *ioport_map(unsigned long port, unsigned int size)
>>                  ^
>> In file included from arch/alpha/kernel/io.c:9:0:
>> /opt/buildbot/slave/qemu-3.2/build/arch/alpha/include/asm/io.h:277:29: note: previous definition of ‘ioport_map’ was here
>>
>> arch/alpha/kernel/io.c:625:6: error: redefinition of ‘ioport_unmap’
>
> This is due to a compiler change, not a code change.  It seems to still
> be broken upstream, as well.
>
Hmm.... You are right, I switched compilers because building alpha in 3.16 failed
with a kallsyms error when using gcc 4.8.3 (or 4.6.3). Oh well.

I switched back to using gcc 4.8.3 for 3.2 and 3.4.

>> mips:malta_defconfig:
>>
>>     CC      arch/mips/kernel/asm-offsets.s
>> In file included from include/linux/mm.h:43:0,
>>                    from arch/mips/kernel/asm-offsets.c:14:
>> /opt/buildbot/slave/qemu-3.2/build/arch/mips/include/asm/pgtable.h: In function 'set_pte':
>> /opt/buildbot/slave/qemu-3.2/build/arch/mips/include/asm/pgtable.h:193:12: error: expected ':' or ')' before 'MIPS_ISA_ARCH_LEVEL'
>> /opt/buildbot/slave/qemu-3.2/build/./Kbuild:81: recipe for target 'arch/mips/kernel/asm-offsets.s' failed
>> make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1
>
> OK, I see how to fix that.
>

Now I get a crash with the nosmp qemu test, and

{standard input}: Assembler messages:
{standard input}:343: Error: Unrecognized opcode `ll$4, 0($3)'
{standard input}:346: Error: Unrecognized opcode `sc$4, 0($3)'
scripts/Makefile.build:305: recipe for target 'arch/mips/mm/ioremap.o' failed
make[2]: *** [arch/mips/mm/ioremap.o] Error 1
make[2]: *** Waiting for unfinished jobs....

when building mips:malta_defconfig. Bisect points to
'MIPS: Adjust set_pte() SMP fix to handle R10000_LLSC_WAR'.

for the build error.

Guenter

Re: Build errors in v3.2-stable-queue

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Sun, 2016-07-31 at 10:34 -0700, Guenter Roeck wrote:
> 
> Now I get a crash with the nosmp qemu test, and

Did you work out what introduced that?

> 
> {standard input}: Assembler messages:
> {standard input}:343: Error: Unrecognized opcode `ll$4, 0($3)'
> {standard input}:346: Error: Unrecognized opcode `sc$4, 0($3)'
> scripts/Makefile.build:305: recipe for target
> 'arch/mips/mm/ioremap.o' failed
> make[2]: *** [arch/mips/mm/ioremap.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> 
> when building mips:malta_defconfig. Bisect points to
> 'MIPS: Adjust set_pte() SMP fix to handle R10000_LLSC_WAR'.
> 
> for the build error.

Oh, I see the problem.  I'll push another version in a moment.

Ben.

-- 
Ben Hutchings
Beware of bugs in the above code;
I have only proved it correct, not tried it. - Donald Knuth

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Build errors in v3.2-stable-queue

[Guenter Roeck]

On Sat, Aug 06, 2016 at 12:26:40AM +0100, Ben Hutchings wrote:
> On Sun, 2016-07-31 at 10:34 -0700, Guenter Roeck wrote:
> >�
> > Now I get a crash with the nosmp qemu test, and
> 
> Did you work out what introduced that?
> 
I didn't try. I can bisect later tonight after the current build completes
if the problem is still seen. I'll let you know.

Guenter

> > 
> > {standard input}: Assembler messages:
> > {standard input}:343: Error: Unrecognized opcode `ll$4, 0($3)'
> > {standard input}:346: Error: Unrecognized opcode `sc$4, 0($3)'
> > scripts/Makefile.build:305: recipe for target
> > 'arch/mips/mm/ioremap.o' failed
> > make[2]: *** [arch/mips/mm/ioremap.o] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > 
> > when building mips:malta_defconfig. Bisect points to
> > 'MIPS: Adjust set_pte() SMP fix to handle R10000_LLSC_WAR'.
> > 
> > for the build error.
> 
> Oh, I see the problem. �I'll push another version in a moment.
> 
> Ben.
> 
> -- 
> Ben Hutchings
> Beware of bugs in the above code;
> I have only proved it correct, not tried it. - Donald Knuth

Re: Build errors in v3.2-stable-queue

[Guenter Roeck]

On 08/05/2016 04:26 PM, Ben Hutchings wrote:
> On Sun, 2016-07-31 at 10:34 -0700, Guenter Roeck wrote:
>>
>> Now I get a crash with the nosmp qemu test, and
>
> Did you work out what introduced that?
>

Bisect says:

# bad: [c85164130167a51006876477e6b4044312960478] ecryptfs: don't allow mmap when the lower fs doesn't support it
# good: [c5d5c18b211dabbfac73670c65dfa4243800adf7] Linux 3.2.81
git bisect start 'HEAD' 'v3.2.81'
# bad: [0d5b7d090ee63c7ab5530fea29beffe989ae385a] parisc: Fix pagefault crash in unaligned __get_user() call
git bisect bad 0d5b7d090ee63c7ab5530fea29beffe989ae385a
# bad: [db17a77a32fe7703a433f428f65f28fddb20d5ba] MIPS: Sync icache & dcache in set_pte_at
git bisect bad db17a77a32fe7703a433f428f65f28fddb20d5ba
# good: [9f4faf23b3c3d719a1005364ac3cca8cb1ca07ca] char: Drop bogus dependency of DEVPORT on !M68K
git bisect good 9f4faf23b3c3d719a1005364ac3cca8cb1ca07ca
# good: [180309d63478b762234b229abf37b0ed4d95fef7] MIPS: Adjust set_pte() SMP fix to handle R10000_LLSC_WAR
git bisect good 180309d63478b762234b229abf37b0ed4d95fef7
# good: [dcbaa9382ed2ded2de553633e58791d057e76ad2] powerpc/mm/hash64: Factor out hash preload psize check
git bisect good dcbaa9382ed2ded2de553633e58791d057e76ad2
# good: [ad1e677bf950f3943e8a3cdd546b2c6202ea7ed4] sched/loadavg: Fix loadavg artifacts on fully idle and on fully loaded systems
git bisect good ad1e677bf950f3943e8a3cdd546b2c6202ea7ed4
# first bad commit: [db17a77a32fe7703a433f428f65f28fddb20d5ba] MIPS: Sync icache & dcache in set_pte_at

After reverting that patch, the problem is gone.

Turns out 3.16 is affected by the same problem, and reverting the patch there fixes it as well.

Guenter

Re: Build errors in v3.2-stable-queue

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

On Fri, 2016-08-05 at 19:40 -0700, Guenter Roeck wrote:
> On 08/05/2016 04:26 PM, Ben Hutchings wrote:
> > 
> > On Sun, 2016-07-31 at 10:34 -0700, Guenter Roeck wrote:
> > > 
> > > 
> > > Now I get a crash with the nosmp qemu test, and
> > 
> > Did you work out what introduced that?
> > 
> 
> Bisect says:
> 
> # bad: [c85164130167a51006876477e6b4044312960478] ecryptfs: don't
> allow mmap when the lower fs doesn't support it
> # good: [c5d5c18b211dabbfac73670c65dfa4243800adf7] Linux 3.2.81
> git bisect start 'HEAD' 'v3.2.81'
> # bad: [0d5b7d090ee63c7ab5530fea29beffe989ae385a] parisc: Fix
> pagefault crash in unaligned __get_user() call
> git bisect bad 0d5b7d090ee63c7ab5530fea29beffe989ae385a
> # bad: [db17a77a32fe7703a433f428f65f28fddb20d5ba] MIPS: Sync icache &
> dcache in set_pte_at
> git bisect bad db17a77a32fe7703a433f428f65f28fddb20d5ba
> # good: [9f4faf23b3c3d719a1005364ac3cca8cb1ca07ca] char: Drop bogus
> dependency of DEVPORT on !M68K
> git bisect good 9f4faf23b3c3d719a1005364ac3cca8cb1ca07ca
> # good: [180309d63478b762234b229abf37b0ed4d95fef7] MIPS: Adjust
> set_pte() SMP fix to handle R10000_LLSC_WAR
> git bisect good 180309d63478b762234b229abf37b0ed4d95fef7
> # good: [dcbaa9382ed2ded2de553633e58791d057e76ad2] powerpc/mm/hash64:
> Factor out hash preload psize check
> git bisect good dcbaa9382ed2ded2de553633e58791d057e76ad2
> # good: [ad1e677bf950f3943e8a3cdd546b2c6202ea7ed4] sched/loadavg: Fix
> loadavg artifacts on fully idle and on fully loaded systems
> git bisect good ad1e677bf950f3943e8a3cdd546b2c6202ea7ed4
> # first bad commit: [db17a77a32fe7703a433f428f65f28fddb20d5ba] MIPS:
> Sync icache & dcache in set_pte_at
> 
> After reverting that patch, the problem is gone.
> 
> Turns out 3.16 is affected by the same problem, and reverting the
> patch there fixes it as well.

Oh well, then I'll revert this and the follow-up.

Ben.

-- 
Ben Hutchings
Beware of bugs in the above code;
I have only proved it correct, not tried it. - Donald Knuth

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Build errors in v3.2-stable-queue

[Guenter Roeck]

On 08/06/2016 03:48 AM, Ben Hutchings wrote:
[ ... ]

>> # first bad commit: [db17a77a32fe7703a433f428f65f28fddb20d5ba] MIPS:
>> Sync icache & dcache in set_pte_at
>>
>> After reverting that patch, the problem is gone.
>>
>> Turns out 3.16 is affected by the same problem, and reverting the
>> patch there fixes it as well.
>
> Oh well, then I'll revert this and the follow-up.
>
Both 3.2 and 3.16 build and test clean now.

Guenter

Re: Build errors in v3.2-stable-queue

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

On Sat, 2016-08-06 at 07:36 -0700, Guenter Roeck wrote:
> On 08/06/2016 03:48 AM, Ben Hutchings wrote:
> [ ... ]
> 
> > 
> > > 
> > > # first bad commit: [db17a77a32fe7703a433f428f65f28fddb20d5ba]
> > > MIPS:
> > > Sync icache & dcache in set_pte_at
> > > 
> > > After reverting that patch, the problem is gone.
> > > 
> > > Turns out 3.16 is affected by the same problem, and reverting the
> > > patch there fixes it as well.
> > 
> > Oh well, then I'll revert this and the follow-up.
> > 
> Both 3.2 and 3.16 build and test clean now.

Great, thanks for checking.

Ben.

-- 
Ben Hutchings
Beware of bugs in the above code;
I have only proved it correct, not tried it. - Donald Knuth

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]