All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominic Curran <dominic.curran@citrix.com>
To: <netdev@vger.kernel.org>
Subject: igb: question regarding auto-negotiation
Date: Fri, 29 Jul 2016 16:37:39 -0700	[thread overview]
Message-ID: <579BE8C3.806@citrix.com> (raw)

Hi

This question refers to igb codebase.
I have a question regarding the setting of hw->mac.autoneg.

Is it correct to say for igb driver:
    "if speed=1000 and duplex=FULL and media_type=COPPER  then  only 
auto-negotiate enable is supported"

i.e.
    with these settings (speed/duplex/media_type) then auto-negotiate 
can _not_ be disabled.  Correct ?

I say this for two reasons:
1) The code in igb_set_spd_dplx() seems to indicate it:

        case SPEED_1000 + DUPLEX_FULL:
                 mac->autoneg = 1;
                 adapter->hw.phy.autoneg_advertised = ADVERTISE_1000_FULL;
                 break;

2) Instrumenting the driver, I always see the autoneg code in 
e1000_check_for_copper_link_generic()  get called after an igb_reset().


Have i understood correctly ?

thanks in advance
dom

             reply	other threads:[~2016-07-29 23:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-29 23:37 Dominic Curran [this message]
2016-07-30  4:35 ` igb: question regarding auto-negotiation Alexander Duyck
2016-08-04 23:01   ` Dominic Curran
2016-08-04 23:16     ` [E1000-devel] " Pieper, Jeffrey E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579BE8C3.806@citrix.com \
    --to=dominic.curran@citrix.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.