From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:36897 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbcHAMwt (ORCPT ); Mon, 1 Aug 2016 08:52:49 -0400 Message-ID: <579F45E4.3030108@osg.samsung.com> Date: Mon, 01 Aug 2016 13:51:48 +0100 From: Luis de Bethencourt MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] fs: befs: remove unneeded initialization to zero References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 31/07/16 21:34, Salah Triki wrote: > off is reinitialized by befs_read_datastream, so no need to init it with > zero in the beginning of befs_bt_read_node. > > Signed-off-by: Salah Triki > --- > fs/befs/btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > index e59ad20..a0e8cfa 100644 > --- a/fs/befs/btree.c > +++ b/fs/befs/btree.c > @@ -196,7 +196,7 @@ static int > befs_bt_read_node(struct super_block *sb, const befs_data_stream *ds, > struct befs_btree_node *node, befs_off_t node_off) > { > - uint off = 0; > + uint off; > > befs_debug(sb, "---> %s", __func__); > > Hi Salah, I will quote Andrew here: "With this code: int foo; bar(&foo); whatever = foo; some versions of gcc will warn that foo might be used uninitialized. Other versions of gcc don't do this. That's why the seemingly-unneeded initializations are there." You can read the rest of his reply to when I sent the same change 2 months ago :) https://lkml.org/lkml/2016/6/1/875 Sorry, I agree with him to keep the code as it is. Nacked. Thanks, Luis