From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37171 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcHAOGD (ORCPT ); Mon, 1 Aug 2016 10:06:03 -0400 Message-ID: <579F5691.4060200@osg.samsung.com> Date: Mon, 01 Aug 2016 15:02:57 +0100 From: Luis de Bethencourt MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 31/07/16 21:34, Salah Triki wrote: > Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned > value by this function is only used once. > > Signed-off-by: Salah Triki > --- > fs/befs/datastream.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c > index b68b6f9..343123c 100644 > --- a/fs/befs/datastream.c > +++ b/fs/befs/datastream.c > @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb, > struct buffer_head *indir_block; > befs_block_run indir_run; > befs_disk_inode_addr *iaddr_array; > - struct befs_sb_info *befs_sb = BEFS_SB(sb); > > befs_blocknr_t indir_start_blk = > - data->max_indirect_range >> befs_sb->block_shift; > + data->max_indirect_range >> BEFS_SB(sb)->block_shift; > > off_t dbl_indir_off = blockno - indir_start_blk; > > This looks to be consistent with other uses of BEFS_SB() when the value is only used once. Thanks, Luis Acked-by: Luis de Bethencourt Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next