From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37198 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbcHAOR4 (ORCPT ); Mon, 1 Aug 2016 10:17:56 -0400 Message-ID: <579F59DF.7090909@osg.samsung.com> Date: Mon, 01 Aug 2016 15:17:03 +0100 From: Luis de Bethencourt MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] fs: befs: remove in vain variable assignment References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 31/07/16 21:34, Salah Triki wrote: > There is no need to init res, since it will be overwitten later by > befs_fblock2brun(). > > Signed-off-by: Salah Triki > --- > fs/befs/linuxvfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index 6bc5b40..2b68c81 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block, > struct super_block *sb = inode->i_sb; > befs_data_stream *ds = &BEFS_I(inode)->i_data.ds; > befs_block_run run = BAD_IADDR; > - int res = 0; > + int res; > ulong disk_off; > > befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld", > Looks good. Thanks Salah, Luis Acked-by: Luis de Bethencourt Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next