All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yu, Mingli" <mingli.yu@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] grub2.inc: run autogen.sh before configure
Date: Tue, 2 Aug 2016 14:25:13 +0800	[thread overview]
Message-ID: <57A03CC9.7010802@windriver.com> (raw)
In-Reply-To: <CAJTo0LadvrbvgPVpC=-pDSBd6ykYyKX=+MqqkNQhzFtbYo=3Ew@mail.gmail.com>



On 2016年08月02日 03:22, Burton, Ross wrote:
>
> On 1 August 2016 at 02:54, <mingli.yu@windriver.com
> <mailto:mingli.yu@windriver.com>> wrote:
>
>     When adding new source files from upstream the autogen.sh
>     script needs to be run
>
>
> This results in this change:
>
> packages/corei7-64-poky-linux/grub-efi/grub-efi: PKGSIZE changed from
> 6787555 to 7524227 (+10%)
>    * FILELIST: added "/usr/sbin/grub-sparc64-setup"
> packages/corei7-64-poky-linux/grub-efi/grub-efi: FILELIST: added
> "/usr/sbin/grub-sparc64-setup"
> packages/corei7-64-poky-linux/grub/grub-dbg: PKGSIZE changed from
> 26159624 to 28829025 (+10%)
> packages/corei7-64-poky-linux/grub/grub: PKGSIZE changed from 5942339 to
> 6679011 (+12%)
>    * FILELIST: added "/usr/sbin/grub-sparc64-setup"
> packages/corei7-64-poky-linux/grub/grub: FILELIST: added
> "/usr/sbin/grub-sparc64-setup"
>
> Is this intentional?

Thanks Ross! This is unintentional, adding autogen.sh in 
do_configure_prepend in grub2.inc results this issue, it is because:

* before add autogen.sh in grub2.inc, there is a patch
./meta/recipes-bsp/grub/files/grub2-remove-sparc64-setup-from-x86-builds.patch
   used to remove grub-sparc64-setup in Makefile.util.am for x86 builds.

* After add autogen.sh in grub2.inc, the previous patch logic to remove
   grub-sparc64-setup in Makefile.util.am for x86 builds is overwritten 
  by autogen.sh (Which will regenerate Makefile.util.am) in do_configure 
phase.

Anyway, resend the V2 patch to remove the side effect.

Thanks,
Grace
> Ross


      reply	other threads:[~2016-08-02  6:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  1:54 [PATCH] grub2.inc: run autogen.sh before configure mingli.yu
2016-08-01 19:22 ` Burton, Ross
2016-08-02  6:25   ` Yu, Mingli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57A03CC9.7010802@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.