All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wangnan (F)" <wangnan0@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf test BPF failing on f24: fix
Date: Wed, 3 Aug 2016 11:41:59 +0800	[thread overview]
Message-ID: <57A16807.9010901@huawei.com> (raw)
In-Reply-To: <57A159EF.7010106@huawei.com>



On 2016/8/3 10:41, Wangnan (F) wrote:
>
>
> On 2016/8/3 3:51, Arnaldo Carvalho de Melo wrote:
>> Hi Wang,
>>
>>     Something changed and a function used in a perf test for BPF is
>> not anymore appearing on vmlinux, albeit still available on
>> /proc/kallsyms:
>>
>> # readelf -wi /lib/modules/4.7.0+/build/vmlinux | grep -w sys_epoll_wait
>> #
>>
>> But:
>>
>> [root@jouet ~]# grep -i sys_epoll_wait /proc/kallsyms
>> ffffffffbd295b50 T SyS_epoll_wait
>> ffffffffbd295b50 T sys_epoll_wait
>> [root@jouet ~]#
>>
>> I noticed that it is some sort of aliasing so I checked the other
>> variant:
>>
>> [root@jouet ~]# readelf -wi /lib/modules/4.7.0+/build/vmlinux | grep 
>> -w SyS_epoll_wait
>>      <2bc9b85>   DW_AT_name        : (indirect string, offset: 
>> 0xe7524): SyS_epoll_wait
>> [root@jouet ~]#
>
> I also see no sys_epoll_wait in output of 'readelf -wi', but I can't
> reproduce the whole problem.
>
>> Trying to use perf probe also produces the same resuls I notice when
>> running the perf test that is failing:
>>
>> [root@jouet ~]# perf probe sys_epoll_wait
>> Failed to find debug information for address ffffffffbd295b50
>> Probe point 'sys_epoll_wait' not found.
>>    Error: Failed to add events.
>
> For me:
>
> # uname -r
> 4.7.0
>
> # perf probe -v sys_epoll_wait
> probe-definition(0): sys_epoll_wait
> symbol:sys_epoll_wait file:(null) line:0 offset:0 return:0 lazy:(null)
> 0 arguments
> Looking at the vmlinux_path (8 entries long)
> Using /lib/modules/4.7.0/build/vmlinux for symbols
> Open Debuginfo file: /lib/modules/4.7.0/build/vmlinux
> Try to find probe point from debuginfo.
> Symbol sys_epoll_wait address found : ffffffff81281240
> Matched function: SyS_epoll_wait
> found inline addr: 0xffffffff81281240
> Probe point found: SyS_epoll_wait+0
> found inline addr: 0xffffffff812813a7
> Probe point found: SyS_epoll_pwait+135
> found inline addr: 0xffffffff8128157a
> Probe point found: compat_SyS_epoll_pwait+154
> Found 3 probe_trace_events.
> Opening /sys/kernel/debug/tracing//kprobe_events write=1
> Writing event: p:probe/sys_epoll_wait _text+2626112
> Writing event: p:probe/sys_epoll_wait_1 _text+2626471
> Writing event: p:probe/sys_epoll_wait_2 _text+2626938
> Added new events:
>   probe:sys_epoll_wait (on sys_epoll_wait)
>   probe:sys_epoll_wait_1 (on sys_epoll_wait)
>   probe:sys_epoll_wait_2 (on sys_epoll_wait)
>
> You can now use it in all perf tools, such as:
>
>     perf record -e probe:sys_epoll_wait_2 -aR sleep 1
>
>
> I'll try different kernel version and kconfig.
>

Still unable reproduce. I tried tip/core/core, which is '4.7.0+'.
I also turns off CONFIG_DEBUG_INFO. In this case, testcase
BPF prologue fails as expected, and basic BPF test is okay.

After removing vmlinux, with kallsyms information
'perf probe sys_epoll_wait' sets only 1 kprobe, but it still
works.

I think there is a bug in your vmlinux. Could you please
do a bisect to find which commit causes this problem?

Thank you.

  reply	other threads:[~2016-08-03  3:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 19:51 perf test BPF failing on f24: fix Arnaldo Carvalho de Melo
2016-08-02 21:03 ` Alexei Starovoitov
2016-08-03  2:15   ` Arnaldo Carvalho de Melo
2016-08-03  2:57     ` Alexei Starovoitov
2016-08-03  2:41 ` Wangnan (F)
2016-08-03  3:41   ` Wangnan (F) [this message]
2016-08-03  8:19 ` Wangnan (F)
2016-08-03 14:45   ` Masami Hiramatsu
2016-08-03 20:04     ` Arnaldo Carvalho de Melo
2016-08-04  6:32       ` Masami Hiramatsu
2016-08-04 12:48         ` Arnaldo Carvalho de Melo
2016-08-04 19:36           ` Arnaldo Carvalho de Melo
2016-08-04 21:47             ` Arnaldo Carvalho de Melo
2016-08-05  9:45               ` Masami Hiramatsu
2016-08-05 14:35                 ` Arnaldo Carvalho de Melo
2016-08-05 15:55                   ` Arnaldo Carvalho de Melo
2016-08-06 10:29                   ` Masami Hiramatsu
2016-08-08 19:33                     ` Arnaldo Carvalho de Melo
2016-08-09 19:17                     ` [tip:perf/urgent] perf probe: Adjust map->reloc offset when finding kernel symbol from map tip-bot for Masami Hiramatsu
2016-08-03 23:08     ` perf test BPF failing on f24: fix Masami Hiramatsu
2016-08-04  1:50       ` Wangnan (F)
2016-08-04  8:47         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57A16807.9010901@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.