From: Arun Siluvery <arun.siluvery@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: fix WaInsertDummyPushConstPs
Date: Wed, 3 Aug 2016 11:52:10 +0100 [thread overview]
Message-ID: <57A1CCDA.2030504@linux.intel.com> (raw)
In-Reply-To: <1470127013-29653-1-git-send-email-matthew.auld@intel.com>
On 02/08/2016 09:36, Matthew Auld wrote:
> As pointed out by Chris Harris, we are using the wrong WA name, it
> should in fact be WaToEnableHwFixForPushConstHWBug, also it should be
> applied from C0 onwards for both BXT and KBL.
>
> Fixes: 7b9005cd45f3 ("drm/i915: Add WaInsertDummyPushConstP for bxt and kbl")
>
> Cc: Chris Harris <chris.harris@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Reported-by: Chris Harris <chris.harris@intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 15acaf6..0df7381 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -1173,8 +1173,8 @@ static int bxt_init_workarounds(struct intel_engine_cs *engine)
> I915_WRITE(GEN8_L3SQCREG1, L3_GENERAL_PRIO_CREDITS(62) |
> L3_HIGH_PRIO_CREDITS(2));
>
> - /* WaInsertDummyPushConstPs:bxt */
> - if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_B0))
> + /* WaToEnableHwFixForPushConstHWBug:bxt */
> + if (IS_BXT_REVID(dev_priv, BXT_REVID_C0, REVID_FOREVER))
> WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
> GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
>
> @@ -1217,8 +1217,8 @@ static int kbl_init_workarounds(struct intel_engine_cs *engine)
> I915_WRITE(GEN8_L3SQCREG4, I915_READ(GEN8_L3SQCREG4) |
> GEN8_LQSC_RO_PERF_DIS);
>
> - /* WaInsertDummyPushConstPs:kbl */
> - if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0))
> + /* WaToEnableHwFixForPushConstHWBug:kbl */
> + if (IS_KBL_REVID(dev_priv, KBL_REVID_C0, REVID_FOREVER))
> WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
> GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
>
>
Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
regards
Arun
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-08-03 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 8:36 [PATCH] drm/i915: fix WaInsertDummyPushConstPs Matthew Auld
2016-08-02 8:58 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-08-05 9:56 ` Matthew Auld
2016-08-05 10:17 ` Joonas Lahtinen
2016-08-03 10:52 ` Arun Siluvery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A1CCDA.2030504@linux.intel.com \
--to=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.